From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966568AbcCPMIE (ORCPT ); Wed, 16 Mar 2016 08:08:04 -0400 Received: from down.free-electrons.com ([37.187.137.238]:45441 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965777AbcCPMIB (ORCPT ); Wed, 16 Mar 2016 08:08:01 -0400 Date: Wed, 16 Mar 2016 13:07:49 +0100 From: Alexandre Belloni To: Nicolas Ferre Cc: linux-arm-kernel@lists.infradead.org, sre@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk Subject: Re: [PATCH v4 2/2] power: reset: at91-shdwc: add new shutdown controller driver Message-ID: <20160316120749.GC20227@piout.net> References: <1457624260-30350-1-git-send-email-nicolas.ferre@atmel.com> <1457624260-30350-3-git-send-email-nicolas.ferre@atmel.com> <20160314202205.GA24894@piout.net> <56E94558.9010506@atmel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56E94558.9010506@atmel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/03/2016 at 12:36:56 +0100, Nicolas Ferre wrote : > I don't agree with you on the 2 last ones. In Documentation/CodingStyle, > it is said that: > > "Chapter 2: Breaking long lines and strings > [..] > Descendants are always substantially shorter than the parent and > are placed substantially to the right." > > Together with the 80 column requirement that I also fulfil, I think that > my code is well aligned. > > So I keep it like this ;-) > checkpatch.pl --strict disagrees with you -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com