From: Tejun Heo <tj@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
cgroups@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-team@fb.com
Subject: Re: [PATCH for-4.6] cgroup: ignore css_sets associated with dead cgroups during migration
Date: Wed, 16 Mar 2016 13:29:17 -0700 [thread overview]
Message-ID: <20160316202917.GD21104@mtj.duckdns.org> (raw)
In-Reply-To: <20160316104527.GG25010@twins.programming.kicks-ass.net>
On Wed, Mar 16, 2016 at 11:45:27AM +0100, Peter Zijlstra wrote:
> This doesn't fix the problem that those zombies might actually still
> want to use the cgroups they're tied to, as reported here:
>
> lkml.kernel.org/r/20160314112057.GT6356@twins.programming.kicks-ass.net
>
> I would strongly suggest to revert 2e91fa7f6d45 wholesale (and mark for
> stable) and try again later.
For the record, this issue was caused by the cpu controller taking
down its css too early during destruction at ->css_offline() and is
fixed by switching to ->css_released() instead.
Thanks.
--
tejun
next prev parent reply other threads:[~2016-03-16 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 0:43 [PATCH for-4.6] cgroup: ignore css_sets associated with dead cgroups during migration Tejun Heo
2016-03-16 10:45 ` Peter Zijlstra
2016-03-16 20:29 ` Tejun Heo [this message]
2016-03-16 20:29 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316202917.GD21104@mtj.duckdns.org \
--to=tj@kernel.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox