From: Kyle Roeschley <kyle.roeschley@ni.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Josh Cartwright <joshc@ni.com>,
Greg KH <gregkh@linuxfoundation.org>, <arnd@arndb.de>,
<linux-kernel@vger.kernel.org>, <jeff.westfahl@ni.com>,
<nathan.sullivan@ni.com>, <xander.huff@ni.com>,
<dvhart@linux.intel.com>
Subject: Re: [PATCH 1/2] misc: add nirtfeatures driver
Date: Wed, 16 Mar 2016 17:30:03 -0500 [thread overview]
Message-ID: <20160316223003.GA13183@senary> (raw)
In-Reply-To: <20160316074824.GT13692@x1>
Hi Lee,
On Wed, Mar 16, 2016 at 07:48:24AM +0000, Lee Jones wrote:
> Is there any reason why the functionality can't be split up into
> different source files? Create an LED driver, a Switch (whatever that
> is) driver and a Watchdog driver, place them in drivers/{appropriate},
> then register from each of them using the MFD API.
I goofed a bit in the commit messages; this driver exposes LEDs and buttons
("switches") and gives access to information such as the reason for last system
reset, FPGA boot mode, and hardware revision among other things. The watchdog
was split into another driver and shouldn't have been mentioned.
As for splitting this driver up, I'm not sure I see the necessity. I'm also
unsure as to the distinction between a platform driver and an MFD driver. In
the case of this driver, the CPLD is always and only present on a specific
series of embedded controllers so I think it might be more appropriate to put
it in drivers/platform. CC-ing Darren Hart, x86 platform driver maintainer, for
input and because I forgot to copy him earlier in this chain.
Kyle Roeschley
National Instruments
prev parent reply other threads:[~2016-03-16 22:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 21:54 [PATCH 1/2] misc: add nirtfeatures driver Kyle Roeschley
2016-03-14 22:05 ` Greg KH
2016-03-14 22:30 ` Josh Cartwright
2016-03-14 22:36 ` Kyle Roeschley
2016-03-16 7:48 ` Lee Jones
2016-03-16 22:30 ` Kyle Roeschley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160316223003.GA13183@senary \
--to=kyle.roeschley@ni.com \
--cc=arnd@arndb.de \
--cc=dvhart@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=jeff.westfahl@ni.com \
--cc=joshc@ni.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan.sullivan@ni.com \
--cc=xander.huff@ni.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox