Re: [PATCH 1/5] ftrace perf: Check sample types only for sampling events

Steven Rostedt
2016-03-18T14:27:54Z

On Wed, 16 Mar 2016 15:34:29 +0100
Jiri Olsa <jolsa@kernel.org> wrote:

> Currently we check sample type for ftrace:function event
> even if it's not created as sampling event. That prevents
> creating ftrace_function event in counting mode.
>
> Making sure we check sample types only for sampling events.
>
> Before:
> $ sudo perf stat -e ftrace:function ls
> ...
>
> Performance counter stats for 'ls':
>
> <not supported> ftrace:function
>
> 0.001983662 seconds time elapsed
>
> After:
> $ sudo perf stat -e ftrace:function ls
> ...
>
> Performance counter stats for 'ls':
>
> 44,498 ftrace:function
>
> 0.037534722 seconds time elapsed
>
> Suggested-by: Namhyung Kim <namhyung@kernel.org>
> Signed-off-by: Jiri Olsa <jolsa@kernel.org>

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve