From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932739AbcCQIJt (ORCPT ); Thu, 17 Mar 2016 04:09:49 -0400 Received: from mga01.intel.com ([192.55.52.88]:64829 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932629AbcCQIJp (ORCPT ); Thu, 17 Mar 2016 04:09:45 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,349,1455004800"; d="scan'208";a="68091065" Date: Thu, 17 Mar 2016 10:09:26 +0200 From: Mika Westerberg To: David Daney Cc: "Rafael J. Wysocki" , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, Robert Richter , Tomasz Nowicki , David Daney Subject: Re: [PATCH] ACPI / property: Export a couple of symbols. Message-ID: <20160317080926.GO1793@lahna.fi.intel.com> References: <1458174199-23615-1-git-send-email-ddaney.cavm@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458174199-23615-1-git-send-email-ddaney.cavm@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 16, 2016 at 05:23:19PM -0700, David Daney wrote: > From: David Daney > > The acpi_dev_prop_read() and acpi_dev_prop_read_single() can be called > by drivers. Add EXPORT_SYMBOL_GPL to them to allow use by modular > drivers. This makes them consistent with acpi_dev_get_property() and > acpi_node_get_property_reference() which are already exported. > > Signed-off-by: David Daney > --- > FWIW: We hope to submit soon Cavium Thunder networking patches that > fail under modular builds without these exports. You should not be using these functions directly in drivers.