From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756350AbcCQItV (ORCPT ); Thu, 17 Mar 2016 04:49:21 -0400 Received: from e06smtp07.uk.ibm.com ([195.75.94.103]:34792 "EHLO e06smtp07.uk.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753583AbcCQItS (ORCPT ); Thu, 17 Mar 2016 04:49:18 -0400 X-IBM-Helo: d06dlp03.portsmouth.uk.ibm.com X-IBM-MailFrom: heiko.carstens@de.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org;linux-s390@vger.kernel.org Date: Thu, 17 Mar 2016 09:49:11 +0100 From: Heiko Carstens To: Christian Borntraeger Cc: Kees Cook , Martin Schwidefsky , linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org, kernel-hardening@lists.openwall.com, Ingo Molnar Subject: Re: [PATCH] s390: disable postinit-readonly for now Message-ID: <20160317084911.GA3995@osiris> References: <20160310173144.GA25532@www.outflux.net> <56E9B860.2060802@de.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56E9B860.2060802@de.ibm.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031708-0029-0000-0000-00000676110E Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 16, 2016 at 08:47:44PM +0100, Christian Borntraeger wrote: > On 03/10/2016 06:31 PM, Kees Cook wrote: > > This is a temporary fix to let lkdtm run again on s390, though it'll > > still fail the ro_after_init tests. Until rodata and ro_after_init > > sections can be split on s390, disable special handling of ro_after_init. > > > > Signed-off-by: Kees Cook > > --- > > for -next ... > > Given that the other patches are already merged in linus master via Ingo, > do you want this to go via Ingo as well? Let's route this via the s390 tree. I will add another patch to get rid of the bogus "This architecture does not have kernel memory protection." message printed to the console, just like parisc. > > --- > > arch/s390/include/asm/cache.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/s390/include/asm/cache.h b/arch/s390/include/asm/cache.h > > index 4d7ccac5fd1d..22da3b34c655 100644 > > --- a/arch/s390/include/asm/cache.h > > +++ b/arch/s390/include/asm/cache.h > > @@ -15,4 +15,7 @@ > > > > #define __read_mostly __attribute__((__section__(".data..read_mostly"))) > > > > +/* Read-only memory is marked before mark_rodata_ro() is called. */ > > +#define __ro_after_init __read_mostly > > +