From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936103AbcCQN3t (ORCPT ); Thu, 17 Mar 2016 09:29:49 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:34907 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936027AbcCQN3s (ORCPT ); Thu, 17 Mar 2016 09:29:48 -0400 Date: Thu, 17 Mar 2016 13:29:43 +0000 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, heiko@sntech.de, patches@linaro.org, linux-rockchip@lists.infradead.org Subject: Re: [PATCH] ARM: Rockchip: Fix use of plain integer as NULL pointer Message-ID: <20160317132943.GC13692@x1> References: <1458213099-13786-1-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1458213099-13786-1-git-send-email-peter.griffin@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nit: Subject line doesn't match the preferred format for the sub-arch. On Thu, 17 Mar 2016, Peter Griffin wrote: > This fixes the following sparse build warning > mach-rockchip/platsmp.c:68:43: Using plain integer as NULL pointer Nit: I would insert a '\n' between your wording and the quoted warning. For added clarity, I usually stick a tab before the quote. > Signed-off-by: Peter Griffin > --- > arch/arm/mach-rockchip/platsmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Patch looks good though: Acked-by: Lee Jones > diff --git a/arch/arm/mach-rockchip/platsmp.c b/arch/arm/mach-rockchip/platsmp.c > index d42a07e..4d827a0 100644 > --- a/arch/arm/mach-rockchip/platsmp.c > +++ b/arch/arm/mach-rockchip/platsmp.c > @@ -65,7 +65,7 @@ static struct reset_control *rockchip_get_core_reset(int cpu) > if (dev) > np = dev->of_node; > else > - np = of_get_cpu_node(cpu, 0); > + np = of_get_cpu_node(cpu, NULL); > > return of_reset_control_get(np, NULL); > } -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog