From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Harvey Hunt <harvey.hunt@imgtec.com>
Cc: Paul Cercueil <paul@crapouillou.net>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Ralf Baechle <ralf@linux-mips.org>,
Alessandro Zummo <a.zummo@towertech.it>,
Paul Burton <paul.burton@imgtec.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mips@linux-mips.org, rtc-linux@googlegroups.com
Subject: Re: [PATCH 3/5] rtc: rtc-jz4740: Add support for devicetree
Date: Thu, 17 Mar 2016 14:56:32 +0100 [thread overview]
Message-ID: <20160317135632.GG3362@piout.net> (raw)
In-Reply-To: <56EAB210.70900@imgtec.com>
On 17/03/2016 at 13:33:04 +0000, Harvey Hunt wrote :
> On 17/03/16 12:08, Alexandre Belloni wrote:
> >On 05/03/2016 at 23:38:49 +0100, Paul Cercueil wrote :
> >>Signed-off-by: Paul Cercueil <paul@crapouillou.net>
> >>---
> >> drivers/rtc/rtc-jz4740.c | 16 +++++++++++++++-
> >> 1 file changed, 15 insertions(+), 1 deletion(-)
> >>
> >>diff --git a/drivers/rtc/rtc-jz4740.c b/drivers/rtc/rtc-jz4740.c
> >>index 47617bd..3914b1c 100644
> >>--- a/drivers/rtc/rtc-jz4740.c
> >>+++ b/drivers/rtc/rtc-jz4740.c
> >>@@ -17,6 +17,7 @@
> >> #include <linux/io.h>
> >> #include <linux/kernel.h>
> >> #include <linux/module.h>
> >>+#include <linux/of_device.h>
> >> #include <linux/platform_device.h>
> >> #include <linux/rtc.h>
> >> #include <linux/slab.h>
> >>@@ -245,6 +246,13 @@ void jz4740_rtc_poweroff(struct device *dev)
> >> }
> >> EXPORT_SYMBOL_GPL(jz4740_rtc_poweroff);
> >>
> >>+static const struct of_device_id jz4740_rtc_of_match[] = {
> >>+ { .compatible = "ingenic,jz4740-rtc", .data = (void *) ID_JZ4740 },
> >>+ { .compatible = "ingenic,jz4780-rtc", .data = (void *) ID_JZ4780 },
> >
> >ingenic is not in Documentation/devicetree/bindings/vendor-prefixes.txt,
> >you have to add it there before using it.
>
> Ingenic is in vendor-prefixes.txt - it was added by Commit f289cc7
> ("devicetree/bindings: add Ingenic Semiconductor vendor prefix").
>
Indeed, I was looking at an old v4.1 based branch instead of master.
You can forget that comment :)
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-17 13:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-05 22:38 [PATCH 1/5] rtc: rtc-jz4740: Add support for the RTC in the jz4780 SoC Paul Cercueil
2016-03-05 22:38 ` [PATCH 2/5] Documentation: dt: Add binding info for jz4740-rtc driver Paul Cercueil
2016-03-06 12:13 ` Sergei Shtylyov
2016-03-17 11:52 ` Rob Herring
2016-03-17 12:04 ` Alexandre Belloni
2016-03-05 22:38 ` [PATCH 3/5] rtc: rtc-jz4740: Add support for devicetree Paul Cercueil
2016-03-17 12:08 ` Alexandre Belloni
2016-03-17 13:33 ` Harvey Hunt
2016-03-17 13:56 ` Alexandre Belloni [this message]
2016-03-05 22:38 ` [PATCH 4/5] rtc: jz4740_rtc: Add support for acting as the system power controller Paul Cercueil
2016-03-17 12:20 ` Alexandre Belloni
2016-03-05 22:38 ` [PATCH 5/5] MIPS: jz4740: Use the jz4740-rtc driver as the " Paul Cercueil
2016-03-14 1:53 ` Ralf Baechle
2016-03-17 12:22 ` Alexandre Belloni
2016-03-17 12:04 ` [PATCH 1/5] rtc: rtc-jz4740: Add support for the RTC in the jz4780 SoC Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160317135632.GG3362@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=harvey.hunt@imgtec.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=paul.burton@imgtec.com \
--cc=paul@crapouillou.net \
--cc=pawel.moll@arm.com \
--cc=ralf@linux-mips.org \
--cc=robh+dt@kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox