* rcutorture: Consider FROZEN hotplug notifier transitions
@ 2016-03-17 10:14 Anna-Maria Gleixner
2016-03-17 15:01 ` Paul E. McKenney
0 siblings, 1 reply; 2+ messages in thread
From: Anna-Maria Gleixner @ 2016-03-17 10:14 UTC (permalink / raw)
To: linux-kernel; +Cc: rt, Anna-Maria Gleixner, Josh Triplett, Paul E. McKenney
The hotplug notifier rcutorture_cpu_notify() doesn't consider the
corresponding CPU_XXX_FROZEN transitions. They occure on
suspend/resume and are usually handled the same way as the
corresponding non frozen transitions.
Mask the switch case action argument with '~CPU_TASKS_FROZEN' to map
CPU_XXX_FROZEN hotplug transitions on corresponding non frozen
transitions.
Cc: Josh Triplett <josh@joshtriplett.org>
Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
---
kernel/rcu/rcutorture.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/kernel/rcu/rcutorture.c
+++ b/kernel/rcu/rcutorture.c
@@ -1598,7 +1598,7 @@ static int rcutorture_cpu_notify(struct
{
long cpu = (long)hcpu;
- switch (action) {
+ switch (action & ~CPU_TASKS_FROZEN) {
case CPU_ONLINE:
case CPU_DOWN_FAILED:
(void)rcutorture_booster_init(cpu);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: rcutorture: Consider FROZEN hotplug notifier transitions
2016-03-17 10:14 rcutorture: Consider FROZEN hotplug notifier transitions Anna-Maria Gleixner
@ 2016-03-17 15:01 ` Paul E. McKenney
0 siblings, 0 replies; 2+ messages in thread
From: Paul E. McKenney @ 2016-03-17 15:01 UTC (permalink / raw)
To: Anna-Maria Gleixner; +Cc: linux-kernel, rt, Josh Triplett
On Thu, Mar 17, 2016 at 11:14:35AM +0100, Anna-Maria Gleixner wrote:
> The hotplug notifier rcutorture_cpu_notify() doesn't consider the
> corresponding CPU_XXX_FROZEN transitions. They occure on
> suspend/resume and are usually handled the same way as the
> corresponding non frozen transitions.
>
> Mask the switch case action argument with '~CPU_TASKS_FROZEN' to map
> CPU_XXX_FROZEN hotplug transitions on corresponding non frozen
> transitions.
>
> Cc: Josh Triplett <josh@joshtriplett.org>
> Cc: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
Queued for review and testing, thank you! If all goes well, I will
push this into the 4.7 merge window (not the current one, but the
next one).
Thanx, Paul
> ---
> kernel/rcu/rcutorture.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -1598,7 +1598,7 @@ static int rcutorture_cpu_notify(struct
> {
> long cpu = (long)hcpu;
>
> - switch (action) {
> + switch (action & ~CPU_TASKS_FROZEN) {
> case CPU_ONLINE:
> case CPU_DOWN_FAILED:
> (void)rcutorture_booster_init(cpu);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-17 15:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-17 10:14 rcutorture: Consider FROZEN hotplug notifier transitions Anna-Maria Gleixner
2016-03-17 15:01 ` Paul E. McKenney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox