From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030799AbcCQPGy (ORCPT ); Thu, 17 Mar 2016 11:06:54 -0400 Received: from e33.co.us.ibm.com ([32.97.110.151]:53607 "EHLO e33.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935868AbcCQPGv (ORCPT ); Thu, 17 Mar 2016 11:06:51 -0400 X-IBM-Helo: d03dlp02.boulder.ibm.com X-IBM-MailFrom: paulmck@linux.vnet.ibm.com X-IBM-RcptTo: linux-kernel@vger.kernel.org Date: Thu, 17 Mar 2016 08:01:31 -0700 From: "Paul E. McKenney" To: Anna-Maria Gleixner Cc: linux-kernel@vger.kernel.org, rt@linutronix.de, Josh Triplett Subject: Re: rcutorture: Consider FROZEN hotplug notifier transitions Message-ID: <20160317150131.GS4287@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <1458209675-177377-1-git-send-email-anna-maria@linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458209675-177377-1-git-send-email-anna-maria@linutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16031715-0009-0000-0000-000015641991 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 17, 2016 at 11:14:35AM +0100, Anna-Maria Gleixner wrote: > The hotplug notifier rcutorture_cpu_notify() doesn't consider the > corresponding CPU_XXX_FROZEN transitions. They occure on > suspend/resume and are usually handled the same way as the > corresponding non frozen transitions. > > Mask the switch case action argument with '~CPU_TASKS_FROZEN' to map > CPU_XXX_FROZEN hotplug transitions on corresponding non frozen > transitions. > > Cc: Josh Triplett > Cc: "Paul E. McKenney" > Signed-off-by: Anna-Maria Gleixner Queued for review and testing, thank you! If all goes well, I will push this into the 4.7 merge window (not the current one, but the next one). Thanx, Paul > --- > kernel/rcu/rcutorture.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/kernel/rcu/rcutorture.c > +++ b/kernel/rcu/rcutorture.c > @@ -1598,7 +1598,7 @@ static int rcutorture_cpu_notify(struct > { > long cpu = (long)hcpu; > > - switch (action) { > + switch (action & ~CPU_TASKS_FROZEN) { > case CPU_ONLINE: > case CPU_DOWN_FAILED: > (void)rcutorture_booster_init(cpu); >