Re: [PATCH 5/7] mtd: provide helper to prepare buffers for DMA operations

Boris Brezillon
2016-03-08T14:46:44Z

On Tue, 8 Mar 2016 19:48:53 +0530
Vinod Koul <vinod.koul@intel.com> wrote:

> On Tue, Mar 08, 2016 at 12:15:13PM +0100, Boris Brezillon wrote:
> >
> > +#ifdef CONFIG_HAS_DMA
>
> Shouldn't this be CONFIG_DMA_ENGINE as you are preparing these descriptors
> for DMA transfer?
>

Nope, scatterlist users are not necessarily using a dmaengine, some IPs
are directly embedding a dedicated DMA engine, which has no driver in
drivers/dma/.

--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering