public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@suse.de>
To: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: rjw@rjwysocki.net, linux-pm@vger.kernel.org, mingo@redhat.com,
	tglx@linutronix.de, x86@kernel.org, hpa@zytor.com,
	linux-kernel@vger.kernel.org, jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH] powercap: intel_rapl: PSys support
Date: Thu, 17 Mar 2016 23:51:00 +0100	[thread overview]
Message-ID: <20160317225100.GA3805@pd.tnic> (raw)
In-Reply-To: <1458253409-13318-1-git-send-email-srinivas.pandruvada@linux.intel.com>

On Thu, Mar 17, 2016 at 03:23:29PM -0700, Srinivas Pandruvada wrote:
> Skylake processor supports a new set of RAPL registers for controlling
> entire platform instead of just CPU package. This is useful for thermal
> and power control when source of power/thermal is not just CPU/GPU.
> This change adds a new platform domain (AKA PSys) to the current
> power capping Intel RAPL driver.
> PSys also supports PL1 (long term) and PL2 (short term) control like
> package domain. This also follows same MSRs for energy and time
> units as package domain.
> Unlike package domain, PSys support requires more than just processor
> level implementation. The other parts in the system need additional
> implementation, which OEMs needs to support. So not all Skylake
> systems will support PSys.
> 
> Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
>  arch/x86/include/asm/msr-index.h |  3 ++
>  drivers/powercap/intel_rapl.c    | 63 ++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 66 insertions(+)
> 
> diff --git a/arch/x86/include/asm/msr-index.h b/arch/x86/include/asm/msr-index.h
> index 2da46ac..bd383f5 100644
> --- a/arch/x86/include/asm/msr-index.h
> +++ b/arch/x86/include/asm/msr-index.h
> @@ -190,6 +190,9 @@
>  #define MSR_PP1_ENERGY_STATUS		0x00000641
>  #define MSR_PP1_POLICY			0x00000642
>  
> +#define MSR_PLATFORM_ENERGY_STATUS	0x0000064d
> +#define MSR_PLATFORM_POWER_LIMIT	0x0000065c

Please add those defines to intel_rapl.c as they're being used only
there, apparently.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
-- 

  reply	other threads:[~2016-03-17 22:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-17 22:23 [PATCH] powercap: intel_rapl: PSys support Srinivas Pandruvada
2016-03-17 22:51 ` Borislav Petkov [this message]
2016-03-17 22:56   ` Srinivas Pandruvada
2016-03-18  1:55     ` Jacob Pan
2016-03-18  9:09       ` Borislav Petkov
2016-03-18  9:52       ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160317225100.GA3805@pd.tnic \
    --to=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=rjw@rjwysocki.net \
    --cc=srinivas.pandruvada@linux.intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox