Re: [PATCH v3 3/9] irqchip/gic-v2: Gather ACPI specific data in a single structure

Christoffer Dall
2016-03-13T18:19:50Z

On Wed, Mar 09, 2016 at 01:18:14PM +0700, Julien Grall wrote:
> Hi Christoffer,
>
> On 09/03/2016 12:47, Christoffer Dall wrote:
> >On Tue, Mar 08, 2016 at 11:29:27AM +0000, Julien Grall wrote:
> >>For now, there is only one member. More member will be added later.
> >
> >questionable commit message
>
> What about:
>
> "The ACPI code requires to use global variables in order to collect
> information from the tables.
>
> For now only a single global variable is used, but more will be
> added in a subsequent patch. To make clear they are ACPI specific,
> gather all the information in a single structure."
>

that's better.

> [...]
>
> >>@@ -1316,7 +1319,7 @@ static int __init gic_v2_acpi_init(struct acpi_subtable_header *header,
> >> return -EINVAL;
> >> }
> >>
> >>- cpu_base = ioremap(cpu_phy_base, ACPI_GIC_CPU_IF_MEM_SIZE);
> >>+ cpu_base = ioremap(acpi_data.cpu_phy_base, ACPI_GIC_CPU_IF_MEM_SIZE);
> >> if (!cpu_base) {
> >> pr_err("Unable to map GICC registers\n");
> >> return -ENOMEM;
> >>--
> >>1.9.1
> >>
> >super nit: I would use cpu_phys_base instead of cpu_phy_base, but I'll
> >leave it up to you.
>
> I will update the commit message, so I will rename the variable too.
>

Thanks,
-Christoffer