From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Javier Martinez Canillas <javier@osg.samsung.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com
Subject: Re: [PATCH v3] rtc: s3c: Don't print an error on probe deferral
Date: Fri, 18 Mar 2016 13:07:17 +0100 [thread overview]
Message-ID: <20160318120717.GD2531@piout.net> (raw)
In-Reply-To: <56EBED45.6070000@osg.samsung.com>
On 18/03/2016 at 08:57:57 -0300, Javier Martinez Canillas wrote :
> >>> But yes, we can at least get rid of the else statement. I don't have a
> >>> strong opinion about the debug information, I left it to avoid someone
> >>> to tell me that I was removing a useful log.
> >>
> >> Although dev_dbg doesn't harm... but isn't driver core printing debug
> >> message already?
> >>
> >
> > I don't think it does or at least I didn't find it when looking
> > at the devm_clk_get() call chain.
> >
> >> BR,
> >> Krzysztof
> >>
>
> Just to make sure that I understood correctly, there's no action I
> should take in order for this patch to be picked right? IOW, the
> current version is OK?
>
I was kind of waiting an answer on the question whether the core already
prints a message when probe dereferral happens because in that case,
there is no need for a debug message and we can indeed simplify the
whole block.
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-03-18 12:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-15 1:38 [PATCH v3] rtc: s3c: Don't print an error on probe deferral Javier Martinez Canillas
2016-03-15 1:50 ` Krzysztof Kozlowski
2016-03-15 1:59 ` Javier Martinez Canillas
2016-03-15 2:26 ` Krzysztof Kozlowski
2016-03-15 2:58 ` Javier Martinez Canillas
2016-03-18 11:57 ` Javier Martinez Canillas
2016-03-18 12:07 ` Alexandre Belloni [this message]
2016-03-18 12:20 ` [rtc-linux] " Krzysztof Kozlowski
2016-03-18 13:56 ` Javier Martinez Canillas
2016-03-18 13:03 ` Alexandre Belloni
2016-03-18 13:44 ` Javier Martinez Canillas
2016-03-18 23:08 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318120717.GD2531@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=javier@osg.samsung.com \
--cc=joe@perches.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox