From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932824AbcCRNDT (ORCPT ); Fri, 18 Mar 2016 09:03:19 -0400 Received: from down.free-electrons.com ([37.187.137.238]:45627 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932306AbcCRNDO (ORCPT ); Fri, 18 Mar 2016 09:03:14 -0400 Date: Fri, 18 Mar 2016 14:03:12 +0100 From: Alexandre Belloni To: Javier Martinez Canillas Cc: Krzysztof Kozlowski , linux-kernel@vger.kernel.org, Joe Perches , linux-samsung-soc@vger.kernel.org, rtc-linux@googlegroups.com Subject: Re: [PATCH v3] rtc: s3c: Don't print an error on probe deferral Message-ID: <20160318130312.GE2531@piout.net> References: <1458005918-7893-1-git-send-email-javier@osg.samsung.com> <56E76A57.7070104@samsung.com> <56E76C6F.5020803@osg.samsung.com> <56E772F2.2030507@samsung.com> <56E77A6A.2090604@osg.samsung.com> <56EBED45.6070000@osg.samsung.com> <20160318120717.GD2531@piout.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160318120717.GD2531@piout.net> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/03/2016 at 13:07:17 +0100, Alexandre Belloni wrote : > On 18/03/2016 at 08:57:57 -0300, Javier Martinez Canillas wrote : > > >>> But yes, we can at least get rid of the else statement. I don't have a > > >>> strong opinion about the debug information, I left it to avoid someone > > >>> to tell me that I was removing a useful log. > > >> > > >> Although dev_dbg doesn't harm... but isn't driver core printing debug > > >> message already? > > >> > > > > > > I don't think it does or at least I didn't find it when looking > > > at the devm_clk_get() call chain. > > > > > >> BR, > > >> Krzysztof > > >> > > > > Just to make sure that I understood correctly, there's no action I > > should take in order for this patch to be picked right? IOW, the > > current version is OK? > > > > I was kind of waiting an answer on the question whether the core already > prints a message when probe dereferral happens because in that case, > there is no need for a debug message and we can indeed simplify the > whole block. Ok, I've found the recent commit 13fcffbbdec4e4863a9a9c7792b821cd6d363a8f I'll take the patch as is. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com