From: Matt Fleming <matt@codeblueprint.co.uk>
To: Daniel Baluta <daniel.baluta@intel.com>
Cc: linux-efi@vger.kernel.org, stefan.stanacar@intel.com,
octavian.purdila@intel.com, linux-kernel@vger.kernel.org,
matthew.k.gumbel@intel.com, mohamed.abbas@intel.com,
constantin.musca@intel.com
Subject: Re: [PATCH v2] efi: Introduce EFI bootloader control driver
Date: Fri, 18 Mar 2016 16:15:05 +0000 [thread overview]
Message-ID: <20160318161505.GU2619@codeblueprint.co.uk> (raw)
In-Reply-To: <1458295910-26557-1-git-send-email-daniel.baluta@intel.com>
On Fri, 18 Mar, at 12:11:50PM, Daniel Baluta wrote:
> From: Matt Gumbel <matthew.k.gumbel@intel.com>
>
> This driver intercepts system reboot requests and populates the
> LoaderEntryOneShot EFI variable with the user-supplied reboot
> argument. EFI bootloaders such as Gummiboot will consume this
> variable and use it to control which OS is booted next.
>
> We use this with Android where reboot() tells the kernel that
> we want to boot into recovery or other non-default OS environment.
>
> It is the bootloader's job to guard against this variable being
> uninitialzed or containing invalid data, and just boot normally
> if that is the case.
>
> Signed-off-by: Matt Gumbel <matthew.k.gumbel@intel.com>
> Signed-off-by: Mohamed Abbas <mohamed.abbas@intel.com>
> Signed-off-by: Constantin Musca <constantin.musca@intel.com>
> Signed-off-by: Daniel Baluta <daniel.baluta@intel.com>
> ---
> Changes since v1:
> * updated Makefile after changing source name from efibc.c -> efi-bc.c
> to comply with naming rules in drivers/firmware/efi/
>
> drivers/firmware/efi/Kconfig | 11 ++
> drivers/firmware/efi/Makefile | 1 +
> drivers/firmware/efi/efi-bc.c | 251 ++++++++++++++++++++++++++++++++++++++++++
> 3 files changed, 263 insertions(+)
> create mode 100644 drivers/firmware/efi/efi-bc.c
Why does this require a driver? Why is it not possible to solve this
problem by creating the variable in userspace before invoking
reboot(2)?
next prev parent reply other threads:[~2016-03-18 16:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-18 10:11 [PATCH v2] efi: Introduce EFI bootloader control driver Daniel Baluta
2016-03-18 11:22 ` kbuild test robot
2016-03-18 12:46 ` kbuild test robot
2016-03-18 16:15 ` Matt Fleming [this message]
2016-03-18 19:18 ` Stanacar, Stefan
2016-03-24 14:47 ` Matt Fleming
2016-03-24 16:15 ` Stanacar, Stefan
2016-03-29 12:53 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160318161505.GU2619@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=constantin.musca@intel.com \
--cc=daniel.baluta@intel.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.k.gumbel@intel.com \
--cc=mohamed.abbas@intel.com \
--cc=octavian.purdila@intel.com \
--cc=stefan.stanacar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox