From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752634AbcCRQqH (ORCPT ); Fri, 18 Mar 2016 12:46:07 -0400 Received: from [198.137.202.9] ([198.137.202.9]:48983 "EHLO bombadil.infradead.org" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751482AbcCRQqC (ORCPT ); Fri, 18 Mar 2016 12:46:02 -0400 Date: Fri, 18 Mar 2016 17:44:41 +0100 From: Peter Zijlstra To: Don Zickus Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org, mingo@kernel.org, tglx@linutronix.de Subject: Re: [PATCH 1/2] watchdog: Fix output Message-ID: <20160318164441.GI6344@twins.programming.kicks-ass.net> References: <20160318152802.407611377@infradead.org> <20160318153022.027826871@infradead.org> <20160318163748.GR64531@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160318163748.GR64531@redhat.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 18, 2016 at 12:37:48PM -0400, Don Zickus wrote: > On Fri, Mar 18, 2016 at 04:28:03PM +0100, Peter Zijlstra wrote: > > The pr_crap() functions generate idiotic output; use printk(). > > > > Broken output: > > > > [ 3538.718135] NMI watchdog: BUG: soft lockup - CPU#2 stuck for 22s! [perf_fuzzer:2646] > > [ 3383.233583] NMI watchdog: Watchdog detected hard LOCKUP on cpu 27 > > > > Fixed output: > > > > [14180.328194] BUG: soft lockup - CPU#2 stuck for 23s! [perf_fuzzer:13650] > > [ 1064.914925] BUG: NMI Watchdog detected hard LOCKUP on cpu 11 > > Would something like this be a better patch? > -#define pr_fmt(fmt) "NMI watchdog: " fmt > +#define pr_fmt(fmt) "Lockup detector: " fmt > - pr_emerg("Watchdog detected hard LOCKUP on cpu %d", this_cpu); > + pr_emerg("Detected hard LOCKUP on cpu %d", this_cpu); That still results in something like: Lockup detector: Detected hard LOCKUP on cpu 22 Which is still weird, doesn't mention NMI nor BUG (and when the NMI triggers it really rather frequently is a dead system).