From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754657AbcCRQtG (ORCPT ); Fri, 18 Mar 2016 12:49:06 -0400 Received: from casper.infradead.org ([85.118.1.10]:38670 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751813AbcCRQtB (ORCPT ); Fri, 18 Mar 2016 12:49:01 -0400 Date: Fri, 18 Mar 2016 17:48:58 +0100 From: Peter Zijlstra To: Don Zickus Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org, mingo@kernel.org, tglx@linutronix.de Subject: Re: [PATCH 1/2] watchdog: Fix output Message-ID: <20160318164858.GX6375@twins.programming.kicks-ass.net> References: <20160318152802.407611377@infradead.org> <20160318153022.027826871@infradead.org> <20160318163748.GR64531@redhat.com> <20160318164441.GI6344@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160318164441.GI6344@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 18, 2016 at 05:44:41PM +0100, Peter Zijlstra wrote: > On Fri, Mar 18, 2016 at 12:37:48PM -0400, Don Zickus wrote: > > Would something like this be a better patch? > > > -#define pr_fmt(fmt) "NMI watchdog: " fmt > > +#define pr_fmt(fmt) "Lockup detector: " fmt You might want to audit all the other pr_ nonsense in that file; a lot of the msgs don't particularly make sense when combined with the prefix. Some are for the NMI thing, others for the soft lockup one. I would just chuck pr_crap() altogether and use sensible text.