* [linux-next:master 8604/12950] net/openvswitch/vport-internal_dev.c:141:6: sparse: symbol 'internal_set_rx_headroom' was not declared. Should it be static?
@ 2016-03-18 16:54 kbuild test robot
2016-03-18 16:54 ` [RFC PATCH linux-next] ovs: internal_set_rx_headroom() can be static kbuild test robot
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2016-03-18 16:54 UTC (permalink / raw)
To: Paolo Abeni; +Cc: kbuild-all, Pravin Shelar, netdev, dev, linux-kernel
tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master
head: 5e3497cca281616e7930b74a0076b7324dcc2057
commit: 3a927bc7cf9d0fbe8f4a8189dd5f8440228f64e7 [8604/12950] ovs: propagate per dp max headroom to all vports
reproduce:
# apt-get install sparse
git checkout 3a927bc7cf9d0fbe8f4a8189dd5f8440228f64e7
make ARCH=x86_64 allmodconfig
make C=1 CF=-D__CHECK_ENDIAN__
sparse warnings: (new ones prefixed by >>)
>> net/openvswitch/vport-internal_dev.c:141:6: sparse: symbol 'internal_set_rx_headroom' was not declared. Should it be static?
Please review and possibly fold the followup patch.
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
^ permalink raw reply [flat|nested] 3+ messages in thread
* [RFC PATCH linux-next] ovs: internal_set_rx_headroom() can be static
2016-03-18 16:54 [linux-next:master 8604/12950] net/openvswitch/vport-internal_dev.c:141:6: sparse: symbol 'internal_set_rx_headroom' was not declared. Should it be static? kbuild test robot
@ 2016-03-18 16:54 ` kbuild test robot
2016-03-18 21:50 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: kbuild test robot @ 2016-03-18 16:54 UTC (permalink / raw)
To: Paolo Abeni; +Cc: kbuild-all, Pravin Shelar, netdev, dev, linux-kernel
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
vport-internal_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/openvswitch/vport-internal_dev.c b/net/openvswitch/vport-internal_dev.c
index 83a5534..7c8b90b 100644
--- a/net/openvswitch/vport-internal_dev.c
+++ b/net/openvswitch/vport-internal_dev.c
@@ -138,7 +138,7 @@ internal_get_stats(struct net_device *dev, struct rtnl_link_stats64 *stats)
return stats;
}
-void internal_set_rx_headroom(struct net_device *dev, int new_hr)
+static void internal_set_rx_headroom(struct net_device *dev, int new_hr)
{
dev->needed_headroom = new_hr;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [RFC PATCH linux-next] ovs: internal_set_rx_headroom() can be static
2016-03-18 16:54 ` [RFC PATCH linux-next] ovs: internal_set_rx_headroom() can be static kbuild test robot
@ 2016-03-18 21:50 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2016-03-18 21:50 UTC (permalink / raw)
To: fengguang.wu; +Cc: pabeni, kbuild-all, pshelar, netdev, dev, linux-kernel
From: kbuild test robot <fengguang.wu@intel.com>
Date: Sat, 19 Mar 2016 00:54:50 +0800
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Looks good, applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-18 21:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-18 16:54 [linux-next:master 8604/12950] net/openvswitch/vport-internal_dev.c:141:6: sparse: symbol 'internal_set_rx_headroom' was not declared. Should it be static? kbuild test robot
2016-03-18 16:54 ` [RFC PATCH linux-next] ovs: internal_set_rx_headroom() can be static kbuild test robot
2016-03-18 21:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox