From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753475AbcCRXIa (ORCPT ); Fri, 18 Mar 2016 19:08:30 -0400 Received: from down.free-electrons.com ([37.187.137.238]:59373 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751134AbcCRXIV (ORCPT ); Fri, 18 Mar 2016 19:08:21 -0400 Date: Sat, 19 Mar 2016 00:08:19 +0100 From: Alexandre Belloni To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Joe Perches , linux-samsung-soc@vger.kernel.org, Krzysztof Kozlowski , rtc-linux@googlegroups.com Subject: Re: [PATCH v3] rtc: s3c: Don't print an error on probe deferral Message-ID: <20160318230819.GF2828@piout.net> References: <1458005918-7893-1-git-send-email-javier@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458005918-7893-1-git-send-email-javier@osg.samsung.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/03/2016 at 22:38:38 -0300, Javier Martinez Canillas wrote : > The clock and source clock looked up by the driver may not be available > just because the clock controller driver was not probed yet so printing > an error in this case is not correct and only adds confusion to users. > > However, knowing that a driver's probe was deferred may be useful so it > can be printed as a debug information. > > Signed-off-by: Javier Martinez Canillas > > --- > > Changes in v3: > - Change debug messages again as suggested by Joe Perches. > > Changes in v2: > - Improve debug messages as suggested by Joe Perches. > > drivers/rtc/rtc-s3c.c | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-) > Applied, thanks. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com