* [PATCH] mfd: da9063: remove unused array mask_events_buf
@ 2016-03-20 18:53 Colin King
2016-03-21 10:42 ` Opensource [Steve Twiss]
2016-03-21 11:53 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Colin King @ 2016-03-20 18:53 UTC (permalink / raw)
To: Support Opensource, Lee Jones; +Cc: linux-kernel
From: Colin Ian King <colin.king@canonical.com>
mask_events_buf is not used, so remove this redundant array.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mfd/da9063-irq.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
index 2630263..0aa760e 100644
--- a/drivers/mfd/da9063-irq.c
+++ b/drivers/mfd/da9063-irq.c
@@ -27,8 +27,6 @@
#define DA9063_REG_EVENT_D_OFFSET 3
#define EVENTS_BUF_LEN 4
-static const u8 mask_events_buf[] = { [0 ... (EVENTS_BUF_LEN - 1)] = ~0 };
-
struct da9063_irq_data {
u16 reg;
u8 mask;
--
2.7.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] mfd: da9063: remove unused array mask_events_buf
2016-03-20 18:53 [PATCH] mfd: da9063: remove unused array mask_events_buf Colin King
@ 2016-03-21 10:42 ` Opensource [Steve Twiss]
2016-03-21 11:53 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Opensource [Steve Twiss] @ 2016-03-21 10:42 UTC (permalink / raw)
To: Colin King, Support Opensource, Lee Jones; +Cc: linux-kernel@vger.kernel.org
On 20 March 2016 18:54 Colin King wrote:
> Subject: [PATCH] mfd: da9063: remove unused array mask_events_buf
> From: Colin Ian King <colin.king@canonical.com>
>
> mask_events_buf is not used, so remove this redundant array.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mfd/da9063-irq.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
> index 2630263..0aa760e 100644
> --- a/drivers/mfd/da9063-irq.c
> +++ b/drivers/mfd/da9063-irq.c
> @@ -27,8 +27,6 @@
> #define DA9063_REG_EVENT_D_OFFSET 3
> #define EVENTS_BUF_LEN 4
I guess EVENTS_BUF_LEN can go as well.
If this is not added, I will send a patch later.
Regards,
Steve
Acked-by: Steve Twiss <stwiss.opensource@diasemi.com>
>
> -static const u8 mask_events_buf[] = { [0 ... (EVENTS_BUF_LEN - 1)] = ~0 };
> -
> struct da9063_irq_data {
> u16 reg;
> u8 mask;
> --
> 2.7.3
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mfd: da9063: remove unused array mask_events_buf
2016-03-20 18:53 [PATCH] mfd: da9063: remove unused array mask_events_buf Colin King
2016-03-21 10:42 ` Opensource [Steve Twiss]
@ 2016-03-21 11:53 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2016-03-21 11:53 UTC (permalink / raw)
To: Colin King; +Cc: Support Opensource, linux-kernel
On Sun, 20 Mar 2016, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> mask_events_buf is not used, so remove this redundant array.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mfd/da9063-irq.c | 2 --
> 1 file changed, 2 deletions(-)
I've amended the $SUBJECT line to conform to the subsystem style.
Patch applied, thanks.
> diff --git a/drivers/mfd/da9063-irq.c b/drivers/mfd/da9063-irq.c
> index 2630263..0aa760e 100644
> --- a/drivers/mfd/da9063-irq.c
> +++ b/drivers/mfd/da9063-irq.c
> @@ -27,8 +27,6 @@
> #define DA9063_REG_EVENT_D_OFFSET 3
> #define EVENTS_BUF_LEN 4
>
> -static const u8 mask_events_buf[] = { [0 ... (EVENTS_BUF_LEN - 1)] = ~0 };
> -
> struct da9063_irq_data {
> u16 reg;
> u8 mask;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-21 11:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-20 18:53 [PATCH] mfd: da9063: remove unused array mask_events_buf Colin King
2016-03-21 10:42 ` Opensource [Steve Twiss]
2016-03-21 11:53 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox