From: Lee Jones <lee.jones@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: remove clock tree on error path
Date: Mon, 21 Mar 2016 11:54:19 +0000 [thread overview]
Message-ID: <20160321115419.GD4140@x1> (raw)
In-Reply-To: <20160227005856.GD28849@codeaurora.org>
On Fri, 26 Feb 2016, Stephen Boyd wrote:
> On 02/19, Andy Shevchenko wrote:
> > There is a potential resource leak in case when ->probe() fails. We have to
> > unregister and remove clock tree which is done here.
> >
> > This is a follow up to previously pushed commit c4726abce63b ("mfd:
> > intel_quark_i2c_gpio: Use clkdev_create()") that prevents double free() when
> > clkdev_drop() followed by kfree() in devm_kcalloc() release stage.
> >
> > I leave Fixes tag here, but the backporting will require to backport the commit
> > c4726abce63b ("mfd: intel_quark_i2c_gpio: Use clkdev_create()") first.
> >
> > Fixes: 60ae5b9f5cdd (mfd: intel_quark_i2c_gpio: Add Intel Quark X1000 I2C-GPIO MFD Driver)
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
>
> Both look fine to me. You may also want to use
> devm_clk_register() instead so that cleanup is easier.
I'm going to apply your Ack in order to show that you've seen and have
no problems with the patch.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2016-03-21 11:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-19 8:42 [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: remove clock tree on error path Andy Shevchenko
2016-02-19 8:42 ` [PATCH v2 2/2] mfd: intel_quark_i2c_gpio: switch to use struct device * Andy Shevchenko
2016-03-21 11:54 ` Lee Jones
2016-02-27 0:58 ` [PATCH v2 1/2] mfd: intel_quark_i2c_gpio: remove clock tree on error path Stephen Boyd
2016-02-29 10:16 ` Andy Shevchenko
2016-03-21 11:54 ` Lee Jones [this message]
2016-03-21 18:40 ` Stephen Boyd
2016-03-10 11:08 ` Andy Shevchenko
2016-03-16 8:46 ` Lee Jones
2016-03-21 11:54 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160321115419.GD4140@x1 \
--to=lee.jones@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).