From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757771AbcCUT0P (ORCPT ); Mon, 21 Mar 2016 15:26:15 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:52833 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754716AbcCUT0N (ORCPT ); Mon, 21 Mar 2016 15:26:13 -0400 Date: Mon, 21 Mar 2016 15:16:46 -0400 From: Greg Kroah-Hartman To: "To .LiMit" <348958453@qq.com> Cc: Mateusz Kulikowski , devel , linux-kernel Subject: Re: [PATCH]rtllib&rtl8192x function naming codestyle change to kernel style Message-ID: <20160321191646.GC27613@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 20, 2016 at 09:47:29PM +0800, To .LiMit wrote: > Hi, I saw drivers/staging/rtl8192e/TODO, checked the files within drivers/staging/rtl8192e/, and I found their function naming codestyle is camelcase, I changed them. But I don't know if I should change all variable naming codestyle or not, so I just changed the function naming of the patch. > > Regards, > > Signed-off-by:Ming Li We need an email address for the signed-off-by line, and it has to match your from: line. Also, please provide a proper changelog entry. And only change one thing at a time, so for this, change only one function per patch. thanks, greg k-h