From: Greg KH <gregkh@linuxfoundation.org>
To: Adonis Settouf <adonis.settouf@gmail.com>
Cc: mateusz.kulikowski@gmail.com, potrzebye@gmail.com,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rtl8192e: Fix warning exceeding characters per line
Date: Mon, 21 Mar 2016 22:07:57 -0400 [thread overview]
Message-ID: <20160322020757.GA5402@kroah.com> (raw)
In-Reply-To: <56E42F2F.2010907@gmail.com>
On Sat, Mar 12, 2016 at 04:01:03PM +0100, Adonis Settouf wrote:
> This patch fixes the checkpatch.pl warning regarding the exceeding 80
> characters on line 36. This patch add a newline after function statement
> on line 52
You did 2 different things in the same patch, that should be 2 patches.
>
> Signed-off-by: Adonis Settouf <adonis.settouf@gmail.com>
> ---
> drivers/staging/rtl8192e/dot11d.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/dot11d.h b/drivers/staging/rtl8192e/dot11d.h
> index 735a199..5cffc8f 100644
> --- a/drivers/staging/rtl8192e/dot11d.h
> +++ b/drivers/staging/rtl8192e/dot11d.h
> @@ -30,8 +30,8 @@ enum dot11d_state {
> };
>
> /**
> - * struct rt_dot11d_info * @CountryIeLen: value greater than 0 if @CountryIeBuf contains
> - * valid country information element.
> + * struct rt_dot11d_info * @CountryIeLen: value greater than 0 if
> + * @CountryIeBuf contains valid country information element.
You forgot to indent like the rest of this comment block did :(
prev parent reply other threads:[~2016-03-22 2:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160312141722.GA388@kerneldev.linux>
2016-03-12 15:01 ` [PATCH] Staging: rtl8192e: Fix warning exceeding characters per line Adonis Settouf
2016-03-22 2:07 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322020757.GA5402@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=adonis.settouf@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mateusz.kulikowski@gmail.com \
--cc=potrzebye@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox