From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758235AbcCVCIA (ORCPT ); Mon, 21 Mar 2016 22:08:00 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:59307 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758125AbcCVCH7 (ORCPT ); Mon, 21 Mar 2016 22:07:59 -0400 Date: Mon, 21 Mar 2016 22:07:57 -0400 From: Greg KH To: Adonis Settouf Cc: mateusz.kulikowski@gmail.com, potrzebye@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: rtl8192e: Fix warning exceeding characters per line Message-ID: <20160322020757.GA5402@kroah.com> References: <20160312141722.GA388@kerneldev.linux> <56E42F2F.2010907@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <56E42F2F.2010907@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 12, 2016 at 04:01:03PM +0100, Adonis Settouf wrote: > This patch fixes the checkpatch.pl warning regarding the exceeding 80 > characters on line 36. This patch add a newline after function statement > on line 52 You did 2 different things in the same patch, that should be 2 patches. > > Signed-off-by: Adonis Settouf > --- > drivers/staging/rtl8192e/dot11d.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/rtl8192e/dot11d.h b/drivers/staging/rtl8192e/dot11d.h > index 735a199..5cffc8f 100644 > --- a/drivers/staging/rtl8192e/dot11d.h > +++ b/drivers/staging/rtl8192e/dot11d.h > @@ -30,8 +30,8 @@ enum dot11d_state { > }; > > /** > - * struct rt_dot11d_info * @CountryIeLen: value greater than 0 if @CountryIeBuf contains > - * valid country information element. > + * struct rt_dot11d_info * @CountryIeLen: value greater than 0 if > + * @CountryIeBuf contains valid country information element. You forgot to indent like the rest of this comment block did :(