From: Greg KH <gregkh@linuxfoundation.org>
To: DaeSeok Youn <daeseok.youn@gmail.com>
Cc: devel <devel@driverdev.osuosl.org>,
Lidza Louina <lidza.louina@gmail.com>,
"driverdev-devel@linuxdriverproject.org"
<driverdev-devel@linuxdriverproject.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] staging: dgnc: use tty_alloc_driver instead of kcalloc
Date: Tue, 22 Mar 2016 09:02:08 -0400 [thread overview]
Message-ID: <20160322130208.GA32381@kroah.com> (raw)
In-Reply-To: <CAHb8M2B5fYUbM3mmHUca9Yc4Fp3UfK1Epo-Y2Caj1W7RnMuz0Q@mail.gmail.com>
On Tue, Mar 22, 2016 at 04:40:24PM +0900, DaeSeok Youn wrote:
> 2016-03-22 6:05 GMT+09:00 Greg KH <gregkh@linuxfoundation.org>:
> > On Mon, Mar 14, 2016 at 01:29:00PM +0900, Daeseok Youn wrote:
> >> the tty_alloc_driver() can allocate memory for ttys and termios.
> >> And also it can release allocated memory easly with using
> >> put_tty_driver().
> >>
> >> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
> >
> > But you broke the driver in the previous patch, you can't do that, each
> > patch has to be 'stand-alone'.
> I am not sure about 'stand-alone'. this patch has to have dependency on
> previous patch..
Yes, that is ok, but your first patch said it was just function
renaming, and then the second patch broke functionality, and the third
fixed it up. You should have a working kernel at each step in your
patch series, which you did not.
> And I have a question not related this thread,
> I had been waiting my patches merged and also have other patches on
> same file(in case of dgnc).
> I couldn't send next patches until previous patches are taken.
> How can I manage my patches for this case?
Just send your new patches and say they depend on the previous ones. My
staging patch queue is almost empty at the moment so odds are I have
already applied, or rejected them.
thanks,
greg k-h
next prev parent reply other threads:[~2016-03-22 13:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-14 4:29 [PATCH 3/3] staging: dgnc: use tty_alloc_driver instead of kcalloc Daeseok Youn
2016-03-21 21:05 ` Greg KH
2016-03-22 7:40 ` DaeSeok Youn
2016-03-22 13:02 ` Greg KH [this message]
2016-03-23 1:38 ` DaeSeok Youn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322130208.GA32381@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daeseok.youn@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox