From: Peter Xu <peterx@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH trace-cmd 1/2] trace-cmd-listen: remove useless printf
Date: Wed, 23 Mar 2016 14:39:52 +0800 [thread overview]
Message-ID: <20160323063952.GL28183@pxdev.xzpeter.org> (raw)
In-Reply-To: <20160322091811.341b2e03@gandalf.local.home>
On Tue, Mar 22, 2016 at 09:18:11AM -0400, Steven Rostedt wrote:
> > diff --git a/trace-listen.c b/trace-listen.c
> > index 1e38eda..12cc9c5 100644
> > --- a/trace-listen.c
> > +++ b/trace-listen.c
> > @@ -721,7 +721,6 @@ static void do_accept_loop(int sfd)
> > do {
> > cfd = accept(sfd, (struct sockaddr *)&peer_addr,
> > &peer_addr_len);
> > - printf("connected!\n");
>
> I probably kept this in for debugging. But I still think there should
> be some kind of logging here. If anything, change this to a debug
> print. I'm working on passing in --debug into the command line here, so
> I'm not going to take this patch. It should be converted to the debug
> coed.
Sure. This is trivial. Please just drop it.
-- peterx
next prev parent reply other threads:[~2016-03-23 6:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-22 7:40 [PATCH trace-cmd 0/2] better error handling during copy Peter Xu
2016-03-22 7:40 ` [PATCH trace-cmd 1/2] trace-cmd-listen: remove useless printf Peter Xu
2016-03-22 13:18 ` Steven Rostedt
2016-03-23 6:39 ` Peter Xu [this message]
2016-03-22 7:40 ` [PATCH trace-cmd 2/2] trace-recorder: better error handling during copy Peter Xu
2016-03-22 13:19 ` Steven Rostedt
2016-03-23 7:02 ` Peter Xu
2016-03-23 7:05 ` [PATCH trace-cmd v2] " Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323063952.GL28183@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox