From: Leon Romanovsky <leon@leon.nu>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Doug Ledford <dledford@redhat.com>,
Matan Barak <matanb@mellanox.com>,
Leon Romanovsky <leonro@mellanox.com>,
Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Sagi Grimberg <sagig@mellanox.com>,
"David S. Miller" <davem@davemloft.net>,
Haggai Eran <haggaie@mellanox.com>,
"majd@mellanox.com" <majd@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>,
Maor Gottlieb <maorg@mellanox.com>,
Haggai Abramovsky <hagaya@mellanox.com>,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/mlx5: fix VFs callback function prototypes
Date: Wed, 23 Mar 2016 12:59:11 +0200 [thread overview]
Message-ID: <20160323105911.GQ25216@leon.nu> (raw)
In-Reply-To: <1458729502-3155671-1-git-send-email-arnd@arndb.de>
On Wed, Mar 23, 2016 at 11:37:45AM +0100, Arnd Bergmann wrote:
> The previous patch that added a couple of callback functions put
> the declarations inside of an #ifdef CONFIG_INFINIBAND_ON_DEMAND_PAGING,
> which causes the build to fail if that option is disabled:
>
> drivers/infiniband/hw/mlx5/main.c: In function 'mlx5_ib_add':
> drivers/infiniband/hw/mlx5/main.c:2358:31: error: 'mlx5_ib_get_vf_config' undeclared (first use in this function)
>
> This moves the four declarations below the #ifdef section so they
> are always available.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: eff901d30e6c ("IB/mlx5: Implement callbacks for manipulating VFs")
Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>
next prev parent reply other threads:[~2016-03-23 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 10:37 [PATCH] IB/mlx5: fix VFs callback function prototypes Arnd Bergmann
2016-03-23 10:59 ` Leon Romanovsky [this message]
2016-03-30 18:26 ` Eli Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323105911.GQ25216@leon.nu \
--to=leon@leon.nu \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=dledford@redhat.com \
--cc=hagaya@mellanox.com \
--cc=haggaie@mellanox.com \
--cc=hal.rosenstock@gmail.com \
--cc=leonro@mellanox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=majd@mellanox.com \
--cc=maorg@mellanox.com \
--cc=matanb@mellanox.com \
--cc=saeedm@mellanox.com \
--cc=sagig@mellanox.com \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox