From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754688AbcCWK72 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Mar 2016 06:59:28 -0400
Received: from mail-wm0-f44.google.com ([74.125.82.44]:34010 "EHLO
	mail-wm0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754383AbcCWK7S (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Mar 2016 06:59:18 -0400
Date: Wed, 23 Mar 2016 12:59:11 +0200
From: Leon Romanovsky <leon@leon.nu>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Doug Ledford <dledford@redhat.com>, Matan Barak <matanb@mellanox.com>,
        Leon Romanovsky <leonro@mellanox.com>,
        Sean Hefty <sean.hefty@intel.com>,
        Hal Rosenstock <hal.rosenstock@gmail.com>,
        Sagi Grimberg <sagig@mellanox.com>,
        "David S. Miller" <davem@davemloft.net>,
        Haggai Eran <haggaie@mellanox.com>,
        "majd@mellanox.com" <majd@mellanox.com>,
        Saeed Mahameed <saeedm@mellanox.com>,
        Maor Gottlieb <maorg@mellanox.com>,
        Haggai Abramovsky <hagaya@mellanox.com>, linux-rdma@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] IB/mlx5: fix VFs callback function prototypes
Message-ID: <20160323105911.GQ25216@leon.nu>
Reply-To: leon@leon.nu
Mail-Followup-To: Arnd Bergmann <arnd@arndb.de>,
	Doug Ledford <dledford@redhat.com>,
	Matan Barak <matanb@mellanox.com>,
	Leon Romanovsky <leonro@mellanox.com>,
	Sean Hefty <sean.hefty@intel.com>,
	Hal Rosenstock <hal.rosenstock@gmail.com>,
	Sagi Grimberg <sagig@mellanox.com>,
	"David S. Miller" <davem@davemloft.net>,
	Haggai Eran <haggaie@mellanox.com>,
	"majd@mellanox.com" <majd@mellanox.com>,
	Saeed Mahameed <saeedm@mellanox.com>,
	Maor Gottlieb <maorg@mellanox.com>,
	Haggai Abramovsky <hagaya@mellanox.com>, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org
References: <1458729502-3155671-1-git-send-email-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1458729502-3155671-1-git-send-email-arnd@arndb.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 23, 2016 at 11:37:45AM +0100, Arnd Bergmann wrote:
> The previous patch that added a couple of callback functions put
> the declarations inside of an #ifdef CONFIG_INFINIBAND_ON_DEMAND_PAGING,
> which causes the build to fail if that option is disabled:
> 
> drivers/infiniband/hw/mlx5/main.c: In function 'mlx5_ib_add':
> drivers/infiniband/hw/mlx5/main.c:2358:31: error: 'mlx5_ib_get_vf_config' undeclared (first use in this function)
> 
> This moves the four declarations below the #ifdef section so they
> are always available.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: eff901d30e6c ("IB/mlx5: Implement callbacks for manipulating VFs")

Thanks,
Reviewed-by: Leon Romanovsky <leonro@mellanox.com>