From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755462AbcCWO1B (ORCPT ); Wed, 23 Mar 2016 10:27:01 -0400 Received: from casper.infradead.org ([85.118.1.10]:52487 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755326AbcCWO07 (ORCPT ); Wed, 23 Mar 2016 10:26:59 -0400 Date: Wed, 23 Mar 2016 15:26:53 +0100 From: Peter Zijlstra To: Jiri Olsa Cc: Steven Rostedt , lkml , Ingo Molnar , Namhyung Kim , Arnaldo Carvalho de Melo Subject: Re: [PATCH 3/5] ftrace perf: Use ftrace_ops::private to store event pointer Message-ID: <20160323142653.GA6344@twins.programming.kicks-ass.net> References: <1458138873-1553-1-git-send-email-jolsa@kernel.org> <1458138873-1553-4-git-send-email-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458138873-1553-4-git-send-email-jolsa@kernel.org> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 16, 2016 at 03:34:31PM +0100, Jiri Olsa wrote: > Fixing this by using ftrace_ops::private value to keep > the perf_event pointer. This way we don't need to search > for triggered event (as tracepoint handler does) and > directly store sample. container_of(ops, struct perf_event, ftrace_ops) would also have worked, right?