From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Marcel Selhorst <tpmdd@selhorst.net>,
"moderated list:TPM DEVICE DRIVER"
<tpmdd-devel@lists.sourceforge.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tpm_atmel: drop tpm_atmel specific fields from tpm_vendor_specific
Date: Wed, 23 Mar 2016 10:42:39 -0600 [thread overview]
Message-ID: <20160323164239.GA16336@obsidianresearch.com> (raw)
In-Reply-To: <1458709822-6677-1-git-send-email-jarkko.sakkinen@linux.intel.com>
On Wed, Mar 23, 2016 at 07:10:22AM +0200, Jarkko Sakkinen wrote:
> Introduced a private struct tpm_atmel_priv that contains the variables
> have_region and region_size that were previously located in struct
> tpm_vendor_specific. These fields were only used by tpm_atmel.
This seems fine to me
Reviewd-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Although I think we should delete this driver
Jason
prev parent reply other threads:[~2016-03-23 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 5:10 [PATCH] tpm_atmel: drop tpm_atmel specific fields from tpm_vendor_specific Jarkko Sakkinen
2016-03-23 16:42 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160323164239.GA16336@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterhuewe@gmx.de \
--cc=tpmdd-devel@lists.sourceforge.net \
--cc=tpmdd@selhorst.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox