* tools lib traceevent: Remove redundant CPU output
@ 2016-03-23 14:16 Steven Rostedt
2016-03-23 18:09 ` Arnaldo Carvalho de Melo
2016-03-24 7:42 ` [tip:perf/urgent] " tip-bot for Steven Rostedt
0 siblings, 2 replies; 3+ messages in thread
From: Steven Rostedt @ 2016-03-23 14:16 UTC (permalink / raw)
To: Arnaldo Carvalho de Melo; +Cc: LKML, Ingo Molnar, Namhyung Kim
Commit a6745330789f "tools lib traceevent: Split pevent_print_event()
into specific functionality functions" Broke apart the function
pevent_print_event() into three functions. The first function prints
the comm, pid and CPU, the second prints the timestamp. But that commit
added the printing of the CPU in the timestamp function, which now
causes pevent_print_event() to duplicate the CPU output.
Remove the redundant printing of the record's CPU from the timestamp
function.
Fixes: a6745330789f "tools lib traceevent: Split pevent_print_event() into specific functionality functions"
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
---
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 190cc886ab91..a8b6357d1ffe 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -5427,10 +5427,8 @@ void pevent_print_event_time(struct pevent *pevent, struct trace_seq *s,
}
if (pevent->latency_format) {
- trace_seq_printf(s, " %3d", record->cpu);
pevent_data_lat_fmt(pevent, s, record);
- } else
- trace_seq_printf(s, " [%03d]", record->cpu);
+ }
if (use_usec_format) {
if (pevent->flags & PEVENT_NSEC_OUTPUT) {
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: tools lib traceevent: Remove redundant CPU output
2016-03-23 14:16 tools lib traceevent: Remove redundant CPU output Steven Rostedt
@ 2016-03-23 18:09 ` Arnaldo Carvalho de Melo
2016-03-24 7:42 ` [tip:perf/urgent] " tip-bot for Steven Rostedt
1 sibling, 0 replies; 3+ messages in thread
From: Arnaldo Carvalho de Melo @ 2016-03-23 18:09 UTC (permalink / raw)
To: Steven Rostedt; +Cc: LKML, Ingo Molnar, Namhyung Kim
Em Wed, Mar 23, 2016 at 10:16:28AM -0400, Steven Rostedt escreveu:
> Commit a6745330789f "tools lib traceevent: Split pevent_print_event()
> into specific functionality functions" Broke apart the function
> pevent_print_event() into three functions. The first function prints
> the comm, pid and CPU, the second prints the timestamp. But that commit
> added the printing of the CPU in the timestamp function, which now
> causes pevent_print_event() to duplicate the CPU output.
>
> Remove the redundant printing of the record's CPU from the timestamp
> function.
Thanks, applied.
- Arnaldo
^ permalink raw reply [flat|nested] 3+ messages in thread
* [tip:perf/urgent] tools lib traceevent: Remove redundant CPU output
2016-03-23 14:16 tools lib traceevent: Remove redundant CPU output Steven Rostedt
2016-03-23 18:09 ` Arnaldo Carvalho de Melo
@ 2016-03-24 7:42 ` tip-bot for Steven Rostedt
1 sibling, 0 replies; 3+ messages in thread
From: tip-bot for Steven Rostedt @ 2016-03-24 7:42 UTC (permalink / raw)
To: linux-tip-commits; +Cc: mingo, hpa, linux-kernel, tglx, acme, namhyung, rostedt
Commit-ID: 4f3c887688a2b0c01b241afcfedbb4e5e4a8e022
Gitweb: http://git.kernel.org/tip/4f3c887688a2b0c01b241afcfedbb4e5e4a8e022
Author: Steven Rostedt <rostedt@goodmis.org>
AuthorDate: Wed, 23 Mar 2016 10:16:28 -0400
Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Wed, 23 Mar 2016 15:08:12 -0300
tools lib traceevent: Remove redundant CPU output
Commit a6745330789f ("tools lib traceevent: Split pevent_print_event()
into specific functionality functions") broke apart the function
pevent_print_event() into three functions.
The first function prints the comm, pid and CPU, the second prints the
timestamp.
But that commit added the printing of the CPU in the timestamp function,
which now causes pevent_print_event() to duplicate the CPU output.
Remove the redundant printing of the record's CPU from the timestamp
function.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Fixes: a6745330789f ("tools lib traceevent: Split pevent_print_event() into specific functionality functions")
Link: http://lkml.kernel.org/r/20160323101628.459375d2@gandalf.local.home
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/lib/traceevent/event-parse.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/tools/lib/traceevent/event-parse.c b/tools/lib/traceevent/event-parse.c
index 190cc88..a8b6357 100644
--- a/tools/lib/traceevent/event-parse.c
+++ b/tools/lib/traceevent/event-parse.c
@@ -5427,10 +5427,8 @@ void pevent_print_event_time(struct pevent *pevent, struct trace_seq *s,
}
if (pevent->latency_format) {
- trace_seq_printf(s, " %3d", record->cpu);
pevent_data_lat_fmt(pevent, s, record);
- } else
- trace_seq_printf(s, " [%03d]", record->cpu);
+ }
if (use_usec_format) {
if (pevent->flags & PEVENT_NSEC_OUTPUT) {
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-03-24 7:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-23 14:16 tools lib traceevent: Remove redundant CPU output Steven Rostedt
2016-03-23 18:09 ` Arnaldo Carvalho de Melo
2016-03-24 7:42 ` [tip:perf/urgent] " tip-bot for Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox