Re: [lustre-devel] [PATCH] Revert "Staging: lustre: o2iblnd: Use sizeof type *pointer instead of sizeof type."

'Greg Kroah-Hartman'
2016-03-23T20:43:42Z

On Wed, Mar 23, 2016 at 08:29:49PM +0000, Simmons, James A. wrote:
>
> >> > > so the right code should be:
> >> > >
> >> > >         sizeof(**net->ibn_tx_ps);
> >> > > and the same for sizeof(**net->ibn_fmr_ps)
> >> > That's a mess, isn't there some other way to fix this up to be more
> >> > "obvious"?
> >> This must have been encountered in the past. How was it handle in those
> >> other cases?
> >
> >I fail to see why it's a mess. It's just **
> >and someone making a mistake.
>
> I have no trouble with **. If we revert it someone else will come along and
> do the same mistake so I think we are stuck with the change to **.

That's fine, but if you do that, just comment it well so that no one
tries to change it again. That's why I can't accept the original patch
in this email thread.

thanks,

greg k-h