From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755043AbcCXCXO (ORCPT ); Wed, 23 Mar 2016 22:23:14 -0400 Received: from mail-pa0-f53.google.com ([209.85.220.53]:36645 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753927AbcCXCXM (ORCPT ); Wed, 23 Mar 2016 22:23:12 -0400 Date: Thu, 24 Mar 2016 11:24:35 +0900 From: Sergey Senozhatsky To: Petr Mladek Cc: Sergey Senozhatsky , Sergey Senozhatsky , Andrew Morton , Jan Kara , Tejun Heo , Tetsuo Handa , linux-kernel@vger.kernel.org, Byungchul Park , Jan Kara Subject: Re: [RFC][PATCH v6 1/2] printk: Make printk() completely async Message-ID: <20160324022435.GA25607@swordfish> References: <1458581130-8677-1-git-send-email-sergey.senozhatsky@gmail.com> <1458581130-8677-2-git-send-email-sergey.senozhatsky@gmail.com> <20160322131106.GA5522@pathway.suse.cz> <20160323003725.GA641@swordfish> <20160323100420.GD5522@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160323100420.GD5522@pathway.suse.cz> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (03/23/16 11:04), Petr Mladek wrote: [..] > if (!need_flush_console) > schedule() > > # did one unnecessary > # cycle to get asleep OK. well, didn't consider it to be a problem, but I'll make it symmetric: we set need_flush_console under logbuf lock, we clear it under logbuf lock. should be simpler. > PS: If you touch the code, please rename printing_func() to > printk_kthread_func() to make it more clear what it does. oh, yes, was going to do it but somehow forgot. -ss