From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: linux-arm-kernel@lists.infradead.org,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@free-electrons.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND
FLATTENED DEVICE TREE BINDINGS),
linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCH 4/4] arm64: dts: marvell: Rename armada-ap806 XOR nodes
Date: Thu, 24 Mar 2016 09:17:26 +0100 [thread overview]
Message-ID: <20160324091726.6eaf83ec@free-electrons.com> (raw)
In-Reply-To: <1458771861-12392-5-git-send-email-afaerber@suse.de>
Hello,
On Wed, 23 Mar 2016 23:24:21 +0100, Andreas Färber wrote:
> Node names should not contain an instance number, the unit address
> serves to distinguish nodes of the same name. So rename the XOR nodes
> to just xor@address, using xorX as label instead.
>
> Fixes: ec7e5a569bce ("arm64: dts: marvell: add Device Tree files for Armada 7K/8K")
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Removing the instance number from the node name is obviously good.
However, I don't think it's really needed to add labels. The XOR
engines are purely "internal" devices, so they are always enabled at
the SoC level.
> "marvell,mv-xor-v2" is not yet referenced from any driver in next-20160323.
Yes. The driver has been submitted, but has received some comments that
I need to address.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2016-03-24 8:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1458771861-12392-1-git-send-email-afaerber@suse.de>
2016-03-23 22:24 ` [PATCH 1/4] arm64: dts: marvell: Clean up armada-3720-db Andreas Färber
2016-03-24 16:11 ` Gregory CLEMENT
2016-03-24 16:46 ` Andreas Färber
2016-03-25 8:16 ` Gregory CLEMENT
2016-04-07 19:00 ` Gregory CLEMENT
2016-03-23 22:24 ` [PATCH 2/4] arm64: dts: marvell: Rename armada-37xx USB node Andreas Färber
2016-03-23 22:24 ` [PATCH 3/4] arm64: dts: marvell: Clean up armada-7040-db Andreas Färber
2016-03-24 8:18 ` Thomas Petazzoni
2016-03-24 10:27 ` Gregory CLEMENT
2016-03-24 10:40 ` Thomas Petazzoni
2016-03-24 13:37 ` Andrew Lunn
2016-03-24 13:59 ` Jason Cooper
2016-03-23 22:24 ` [PATCH 4/4] arm64: dts: marvell: Rename armada-ap806 XOR nodes Andreas Färber
2016-03-24 8:17 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160324091726.6eaf83ec@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=afaerber@suse.de \
--cc=andrew@lunn.ch \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregory.clement@free-electrons.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox