From: Peter Zijlstra <peterz@infradead.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung@kernel.org>,
Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [PATCH 3/5] ftrace perf: Use ftrace_ops::private to store event pointer
Date: Thu, 24 Mar 2016 11:40:59 +0100 [thread overview]
Message-ID: <20160324104059.GO6356@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <20160324094711.GB8893@krava.brq.redhat.com>
On Thu, Mar 24, 2016 at 10:47:11AM +0100, Jiri Olsa wrote:
> On Wed, Mar 23, 2016 at 03:26:53PM +0100, Peter Zijlstra wrote:
> > On Wed, Mar 16, 2016 at 03:34:31PM +0100, Jiri Olsa wrote:
> > > Fixing this by using ftrace_ops::private value to keep
> > > the perf_event pointer. This way we don't need to search
> > > for triggered event (as tracepoint handler does) and
> > > directly store sample.
> >
> > container_of(ops, struct perf_event, ftrace_ops) would also have worked,
> > right?
>
> yes, I think that would work too
OK, no need to change, I was just seeing if I actually understood the
code.
next prev parent reply other threads:[~2016-03-24 10:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-16 14:34 [PATCHv2 0/5] ftrace perf: Fixes and speedup Jiri Olsa
2016-03-16 14:34 ` [PATCH 1/5] ftrace perf: Check sample types only for sampling events Jiri Olsa
2016-03-18 14:27 ` Steven Rostedt
2016-03-31 9:25 ` [tip:perf/core] ftrace/perf: " tip-bot for Jiri Olsa
2016-03-16 14:34 ` [PATCH 2/5] ftrace perf: Move exclude_kernel tracepoint check to init event Jiri Olsa
2016-03-18 14:28 ` Steven Rostedt
2016-03-23 10:41 ` Peter Zijlstra
2016-03-24 9:56 ` Jiri Olsa
2016-03-24 10:49 ` Peter Zijlstra
2016-03-24 12:25 ` Jiri Olsa
2016-03-24 13:00 ` Peter Zijlstra
2016-03-24 13:30 ` Jiri Olsa
2016-03-16 14:34 ` [PATCH 3/5] ftrace perf: Use ftrace_ops::private to store event pointer Jiri Olsa
2016-03-18 14:28 ` Steven Rostedt
2016-03-23 14:26 ` Peter Zijlstra
2016-03-24 9:47 ` Jiri Olsa
2016-03-24 10:40 ` Peter Zijlstra [this message]
2016-03-16 14:34 ` [PATCH 4/5] ftrace: Make ftrace_hash_rec_enable return update bool Jiri Olsa
2016-03-17 0:23 ` Namhyung Kim
2016-03-16 14:34 ` [PATCH 5/5] ftrace: Update dynamic ftrace calls only if necessary Jiri Olsa
2016-03-17 0:25 ` Namhyung Kim
2016-03-18 14:27 ` Steven Rostedt
-- strict thread matches above, loose matches on Subject: below --
2016-03-09 20:46 [RFC 0/5] ftrace perf: Fixes and speedup Jiri Olsa
2016-03-09 20:46 ` [PATCH 3/5] ftrace perf: Use ftrace_ops::private to store event pointer Jiri Olsa
2016-03-10 1:29 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160324104059.GO6356@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).