From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757018AbcCXKlO (ORCPT ); Thu, 24 Mar 2016 06:41:14 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:43146 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755362AbcCXKlF (ORCPT ); Thu, 24 Mar 2016 06:41:05 -0400 Date: Thu, 24 Mar 2016 11:40:59 +0100 From: Peter Zijlstra To: Jiri Olsa Cc: Jiri Olsa , Steven Rostedt , lkml , Ingo Molnar , Namhyung Kim , Arnaldo Carvalho de Melo Subject: Re: [PATCH 3/5] ftrace perf: Use ftrace_ops::private to store event pointer Message-ID: <20160324104059.GO6356@twins.programming.kicks-ass.net> References: <1458138873-1553-1-git-send-email-jolsa@kernel.org> <1458138873-1553-4-git-send-email-jolsa@kernel.org> <20160323142653.GA6344@twins.programming.kicks-ass.net> <20160324094711.GB8893@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160324094711.GB8893@krava.brq.redhat.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 24, 2016 at 10:47:11AM +0100, Jiri Olsa wrote: > On Wed, Mar 23, 2016 at 03:26:53PM +0100, Peter Zijlstra wrote: > > On Wed, Mar 16, 2016 at 03:34:31PM +0100, Jiri Olsa wrote: > > > Fixing this by using ftrace_ops::private value to keep > > > the perf_event pointer. This way we don't need to search > > > for triggered event (as tracepoint handler does) and > > > directly store sample. > > > > container_of(ops, struct perf_event, ftrace_ops) would also have worked, > > right? > > yes, I think that would work too OK, no need to change, I was just seeing if I actually understood the code.