public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] mfd: syscon: include errno.h from header
@ 2016-03-23 10:36 Arnd Bergmann
  2016-03-24 11:05 ` Lee Jones
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-03-23 10:36 UTC (permalink / raw)
  To: Lee Jones; +Cc: Arnd Bergmann, Philipp Zabel, linux-kernel

The syscon header uses the ENOTSUPP error constant, but doesn't
include the header that defines it. This causes a build error
after the imx pinctrl driver started using syscon:

include/linux/mfd/syscon.h: In function 'syscon_node_to_regmap':
include/linux/mfd/syscon.h:32:18: error: 'ENOTSUPP' undeclared (first use in this function)
  return ERR_PTR(-ENOTSUPP);
                  ^~~~~~~~

This adds the missing #include.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 8626ada871f1 ("pinctrl: imx: attach iomuxc device to gpr syscon")
---
 include/linux/mfd/syscon.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h
index 1088149be0c9..40a76b97b7ab 100644
--- a/include/linux/mfd/syscon.h
+++ b/include/linux/mfd/syscon.h
@@ -16,6 +16,7 @@
 #define __LINUX_MFD_SYSCON_H__
 
 #include <linux/err.h>
+#include <linux/errno.h>
 
 struct device_node;
 
-- 
2.7.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] mfd: syscon: include errno.h from header
  2016-03-23 10:36 [PATCH] mfd: syscon: include errno.h from header Arnd Bergmann
@ 2016-03-24 11:05 ` Lee Jones
  0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2016-03-24 11:05 UTC (permalink / raw)
  To: Arnd Bergmann; +Cc: Philipp Zabel, linux-kernel

On Wed, 23 Mar 2016, Arnd Bergmann wrote:

> The syscon header uses the ENOTSUPP error constant, but doesn't
> include the header that defines it. This causes a build error
> after the imx pinctrl driver started using syscon:
> 
> include/linux/mfd/syscon.h: In function 'syscon_node_to_regmap':
> include/linux/mfd/syscon.h:32:18: error: 'ENOTSUPP' undeclared (first use in this function)
>   return ERR_PTR(-ENOTSUPP);
>                   ^~~~~~~~
> 
> This adds the missing #include.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 8626ada871f1 ("pinctrl: imx: attach iomuxc device to gpr syscon")
> ---
>  include/linux/mfd/syscon.h | 1 +
>  1 file changed, 1 insertion(+)

Applied, thanks.

> diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h
> index 1088149be0c9..40a76b97b7ab 100644
> --- a/include/linux/mfd/syscon.h
> +++ b/include/linux/mfd/syscon.h
> @@ -16,6 +16,7 @@
>  #define __LINUX_MFD_SYSCON_H__
>  
>  #include <linux/err.h>
> +#include <linux/errno.h>
>  
>  struct device_node;
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-03-24 11:05 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-23 10:36 [PATCH] mfd: syscon: include errno.h from header Arnd Bergmann
2016-03-24 11:05 ` Lee Jones

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox