From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757521AbcCXLF2 (ORCPT ); Thu, 24 Mar 2016 07:05:28 -0400 Received: from mail-wm0-f48.google.com ([74.125.82.48]:34748 "EHLO mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757495AbcCXLFT (ORCPT ); Thu, 24 Mar 2016 07:05:19 -0400 Date: Thu, 24 Mar 2016 11:05:09 +0000 From: Lee Jones To: Arnd Bergmann Cc: Philipp Zabel , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: syscon: include errno.h from header Message-ID: <20160324110509.GA3496@x1> References: <1458729422-3136412-1-git-send-email-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1458729422-3136412-1-git-send-email-arnd@arndb.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Mar 2016, Arnd Bergmann wrote: > The syscon header uses the ENOTSUPP error constant, but doesn't > include the header that defines it. This causes a build error > after the imx pinctrl driver started using syscon: > > include/linux/mfd/syscon.h: In function 'syscon_node_to_regmap': > include/linux/mfd/syscon.h:32:18: error: 'ENOTSUPP' undeclared (first use in this function) > return ERR_PTR(-ENOTSUPP); > ^~~~~~~~ > > This adds the missing #include. > > Signed-off-by: Arnd Bergmann > Fixes: 8626ada871f1 ("pinctrl: imx: attach iomuxc device to gpr syscon") > --- > include/linux/mfd/syscon.h | 1 + > 1 file changed, 1 insertion(+) Applied, thanks. > diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h > index 1088149be0c9..40a76b97b7ab 100644 > --- a/include/linux/mfd/syscon.h > +++ b/include/linux/mfd/syscon.h > @@ -16,6 +16,7 @@ > #define __LINUX_MFD_SYSCON_H__ > > #include > +#include > > struct device_node; > -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog