From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757603AbcCXNAu (ORCPT ); Thu, 24 Mar 2016 09:00:50 -0400 Received: from casper.infradead.org ([85.118.1.10]:48023 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757526AbcCXNAt (ORCPT ); Thu, 24 Mar 2016 09:00:49 -0400 Date: Thu, 24 Mar 2016 14:00:45 +0100 From: Peter Zijlstra To: Jiri Olsa , gg@twins.programming.kicks-ass.net Cc: Jiri Olsa , Steven Rostedt , lkml , Ingo Molnar , Namhyung Kim , Arnaldo Carvalho de Melo Subject: Re: [PATCH 2/5] ftrace perf: Move exclude_kernel tracepoint check to init event Message-ID: <20160324130045.GR6356@twins.programming.kicks-ass.net> References: <1458138873-1553-1-git-send-email-jolsa@kernel.org> <1458138873-1553-3-git-send-email-jolsa@kernel.org> <20160323104129.GZ6344@twins.programming.kicks-ass.net> <20160324095648.GC8893@krava.brq.redhat.com> <20160324104934.GQ6356@twins.programming.kicks-ass.net> <20160324122544.GA12449@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160324122544.GA12449@krava.brq.redhat.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 24, 2016 at 01:25:44PM +0100, Jiri Olsa wrote: > > > > > $ sudo perf record -e sched:sched_switch:u ls > > > > > $ sudo /perf script | wc -l > > > > > 0 > > And its not like the [uk] flags are hard to implement here. > > sched:sched_switch:u ? As per the above, its implemented and correct. The answer is 0. The only problem is that currently it assumes all tracepoint events are from the kernel, and that is wrong for uprobes. But returning an error is not right, its a valid configuration, a daft one, sure, but not invalid. Similarly uprobe:foo:k is daft, but broken.