From: Jisheng Zhang <jszhang@marvell.com>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Adrian Hunter <adrian.hunter@intel.com>,
<ludovic.desroches@atmel.com>,
"Ivan T. Ivanov" <ivan.ivanov@linaro.org>,
<linux-mmc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-samsung-soc@vger.kernel.org>
Subject: Re: Warnings for invalid VDD (sdhci-s3c)
Date: Thu, 24 Mar 2016 16:24:49 +0800 [thread overview]
Message-ID: <20160324162449.29c9cf78@xhacker> (raw)
In-Reply-To: <56F3A0B7.4050509@samsung.com>
Hi,
On Thu, 24 Mar 2016 17:09:27 +0900 Jaehoon Chung wrote:
> Hi,
>
> On 03/24/2016 04:58 PM, Jisheng Zhang wrote:
> > Hi,
> >
> > On Thu, 24 Mar 2016 16:28:56 +0900 Krzysztof Kozlowski wrote:
> >
> >> Hi,
> >>
> >> After 918f4cbd4340 ("mmc: sdhci: restore behavior when setting VDD via
> >> external regulator") On Trats2 board I see warnings for invalid VDD
> >> value (2.8V):
> >>
> >> [ 3.119656] ------------[ cut here ]------------
> >> [ 3.119666] WARNING: CPU: 3 PID: 90 at
> >> ../drivers/mmc/host/sdhci.c:1234 sdhci_do_set_ios+0x4cc/0x5e0
> >> [ 3.119669] mmc0: Invalid vdd 0x10
> >
> > Per my understanding, the wrong vdd indicates a wrong ocr, what's the voltage of
> > this host's vmmc regulator?
>
> As i know, it's fixed-voltage with gpio on trats2. It's 2.8V.
> I didn't check this entirely..need to check ocr value.
>
I may know the reason. the vmmc is 2.8v, then mmc_regulator_get_supply() convert
the value to a ocr as 0x10. The key here is that the 2.8v is invalid in SDHCI
case and isn't accepted by current sdhci driver.
I dunno the elegant solution to handle this case, let's wait for sdhci maintainers
idea.
Thanks,
Jisheng
next prev parent reply other threads:[~2016-03-24 8:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 7:28 Warnings for invalid VDD (sdhci-s3c) Krzysztof Kozlowski
2016-03-24 7:58 ` Jisheng Zhang
2016-03-24 8:09 ` Jaehoon Chung
2016-03-24 8:24 ` Jisheng Zhang [this message]
2016-03-24 8:42 ` Krzysztof Kozlowski
2016-03-24 13:11 ` Adrian Hunter
2016-03-24 13:21 ` Adrian Hunter
2016-03-24 13:45 ` Jisheng Zhang
2016-03-24 14:27 ` Ludovic Desroches
2016-03-28 6:07 ` Krzysztof Kozlowski
2016-03-29 9:39 ` Adrian Hunter
2016-03-29 9:45 ` [PATCH V3] mmc: sdhci: Fix regression setting power on Trats2 board Adrian Hunter
2016-03-29 10:00 ` Jisheng Zhang
2016-03-29 10:02 ` Jaehoon Chung
2016-03-29 10:25 ` Anand Moon
2016-03-29 10:47 ` Ulf Hansson
2016-03-24 13:31 ` Warnings for invalid VDD (sdhci-s3c) Markus Reichl
2016-03-24 14:03 ` Ludovic Desroches
2016-03-24 14:34 ` Adrian Hunter
2016-03-27 7:41 ` Anand Moon
2016-03-28 5:33 ` Krzysztof Kozlowski
2016-03-28 11:39 ` Anand Moon
2016-03-29 7:59 ` Adrian Hunter
2016-03-29 10:05 ` Anand Moon
2016-03-24 13:30 ` Tobias Jakobi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160324162449.29c9cf78@xhacker \
--to=jszhang@marvell.com \
--cc=adrian.hunter@intel.com \
--cc=ivan.ivanov@linaro.org \
--cc=jh80.chung@samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=ludovic.desroches@atmel.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox