From: Mark Brown <broonie@kernel.org>
To: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regmap: mmio: Fix value endianness selection
Date: Fri, 25 Mar 2016 11:24:59 +0000 [thread overview]
Message-ID: <20160325112459.GD2566@sirena.org.uk> (raw)
In-Reply-To: <2609570.vvhKhym0nL@ws-stein>
[-- Attachment #1: Type: text/plain, Size: 686 bytes --]
On Wed, Mar 23, 2016 at 03:20:46PM +0100, Alexander Stein wrote:
> The difference in those drivers is that syscon manually sets
> config.val_format_endian before calling regmap_init_mmio.
> spi-fsl-dspi does not. I guess this driver relies on this configuration being
> done in regmap_get_val_endian. But this is never reached because after setting
Does this IP exist in configurations where it is anything other than big
endian? If not then this probably shouldn't be in DT.
> map->reg_read this code is skipped due to "goto skip_format_initialization;"
> IMHO a call to regmap_get_val_endian should be added to
> regmap_mmio_gen_context.
That sounds reasonable.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-03-25 11:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 13:17 [PATCH] regmap: mmio: Fix value endianness selection Mark Brown
2016-03-23 13:38 ` Alexander Stein
2016-03-23 13:42 ` Applied "regmap: mmio: Fix value endianness selection" to the regmap tree Mark Brown
2016-03-23 14:20 ` [PATCH] regmap: mmio: Fix value endianness selection Alexander Stein
2016-03-25 11:24 ` Mark Brown [this message]
2016-03-29 6:10 ` Alexander Stein
2016-03-29 6:11 ` Stefan Agner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160325112459.GD2566@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexander.stein@systec-electronic.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox