Re: [PATCH] regulator: twl: Enable regulators over the powerbus as well

Mark Brown
2016-03-25T17:06:11Z

[-- Attachment #1: Type: text/plain, Size: 825 bytes --]

On Fri, Mar 25, 2016 at 06:50:18PM +0200, Ivaylo Dimitrov wrote:
> On 25.03.2016 18:19, Mark Brown wrote:

> >What makes you claim that this is a bug in the framework? Does anything
> >in the machine configuration say that changing the modes is allowed?

> My understanding is that regulator core have to make sure an enabled
> regulator to be in REGULATOR_STATUS_NORMAL. Now it enables the regulator,

No, absolutely not. Modes are completely orthogonal to enabling and
disabling the regulator - modes reflect an efficiency/accuracy tradeoff
in the regulation, they are nothing to do with the regulator being
enabled. Setting a mode should not affect the regulator enable state
and enabling the regulator should not affect the mode.

> It might be that I am not getting the logic behind.

Yes, that seems to be the case.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]