From: Mark Brown <broonie@kernel.org>
To: Sebastian Reichel <sre@kernel.org>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
tony@atomide.com, lgirdwood@gmail.com,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: twl: Enable regulators over the powerbus as well
Date: Fri, 25 Mar 2016 17:23:22 +0000 [thread overview]
Message-ID: <20160325172322.GC5028@sirena.org.uk> (raw)
In-Reply-To: <20160325164750.GA14392@earth>
[-- Attachment #1: Type: text/plain, Size: 708 bytes --]
On Fri, Mar 25, 2016 at 05:47:50PM +0100, Sebastian Reichel wrote:
> I just tried to describe what's going on, so that you can see the
> whole picture. I don't agree with the patch and think that the mode
> should be switched to normal at probe time. I assumed, that you
> would suggest the correct solution if I describe the problem.
Well, I'm not 100% sure what's going on. If there is a constraint in
the system that requires setting the mode then something needs to
set that but it sounds like it might be more the case that the mode
support in this driver is just broken at the minute if it's not
orthogonal to the enable support. Perhaps the mode API is being used
for suspend states or something?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
prev parent reply other threads:[~2016-03-25 17:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 19:22 [PATCH] regulator: twl: Enable regulators over the powerbus as well Ivaylo Dimitrov
2016-03-25 11:17 ` Mark Brown
2016-03-25 15:02 ` Sebastian Reichel
2016-03-25 15:54 ` Mark Brown
2016-03-25 16:09 ` Ivaylo Dimitrov
2016-03-25 16:19 ` Mark Brown
2016-03-25 16:50 ` Ivaylo Dimitrov
2016-03-25 17:05 ` Mark Brown
2016-03-25 17:22 ` Ivaylo Dimitrov
2016-03-25 18:20 ` Mark Brown
2016-03-25 20:19 ` Sebastian Reichel
2016-03-25 22:28 ` Mark Brown
2016-03-26 6:18 ` Ivaylo Dimitrov
2016-03-25 16:47 ` Sebastian Reichel
2016-03-25 17:23 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160325172322.GC5028@sirena.org.uk \
--to=broonie@kernel.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox