* [patch 2/2] drm/exynos: mic: remove some dead code
@ 2016-03-17 10:39 Dan Carpenter
2016-03-25 8:51 ` Inki Dae
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2016-03-17 10:39 UTC (permalink / raw)
To: Inki Dae
Cc: Joonyoung Shim, Seung-Woo Kim, Kyungmin Park, David Airlie,
Kukjin Kim, Krzysztof Kozlowski, dri-devel, linux-samsung-soc,
linux-kernel, kernel-janitors
We know "ret" is zero and the test makes static checkers complain so
let's delete this printk.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
index 890c9b1..12db353 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
@@ -130,8 +130,6 @@ static void mic_set_path(struct exynos_mic *mic, bool enable)
val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
regmap_write(mic->sysreg, DSD_CFG_MUX, val);
- if (ret)
- DRM_ERROR("mic: Failed to read system register\n");
}
static int mic_sw_reset(struct exynos_mic *mic)
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch 2/2] drm/exynos: mic: remove some dead code
2016-03-17 10:39 [patch 2/2] drm/exynos: mic: remove some dead code Dan Carpenter
@ 2016-03-25 8:51 ` Inki Dae
2016-03-25 20:05 ` [patch 2/2 v2] drm/exynos: fix a warning message Dan Carpenter
2016-03-25 20:09 ` [patch 2/2] drm/exynos: mic: remove some dead code Dan Carpenter
0 siblings, 2 replies; 4+ messages in thread
From: Inki Dae @ 2016-03-25 8:51 UTC (permalink / raw)
To: Dan Carpenter
Cc: Joonyoung Shim, Seung-Woo Kim, Kyungmin Park, David Airlie,
Kukjin Kim, Krzysztof Kozlowski, dri-devel, linux-samsung-soc,
linux-kernel, kernel-janitors
Hi Dan,
2016년 03월 17일 19:39에 Dan Carpenter 이(가) 쓴 글:
> We know "ret" is zero and the test makes static checkers complain so
> let's delete this printk.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> index 890c9b1..12db353 100644
> --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> @@ -130,8 +130,6 @@ static void mic_set_path(struct exynos_mic *mic, bool enable)
> val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
>
> regmap_write(mic->sysreg, DSD_CFG_MUX, val);
> - if (ret)
> - DRM_ERROR("mic: Failed to read system register\n");
I think we missed to keep return value from regmap_write function,
ret = regmap_write(mic->sysreg, ....);
if (ret)
...
Thanks,
Inki Dae
> }
>
> static int mic_sw_reset(struct exynos_mic *mic)
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [patch 2/2 v2] drm/exynos: fix a warning message
2016-03-25 8:51 ` Inki Dae
@ 2016-03-25 20:05 ` Dan Carpenter
2016-03-25 20:09 ` [patch 2/2] drm/exynos: mic: remove some dead code Dan Carpenter
1 sibling, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-03-25 20:05 UTC (permalink / raw)
To: Inki Dae
Cc: Joonyoung Shim, Seung-Woo Kim, Kyungmin Park, David Airlie,
Kukjin Kim, Krzysztof Kozlowski, dri-devel, linux-samsung-soc,
linux-kernel, kernel-janitors
The "ret = regmap_write()" assignment was missing so this error message
is never printed.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
v2: in v1 I just deleted the error message
diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
index 9869d70..ea2ea17 100644
--- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
+++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
@@ -129,7 +129,7 @@ static void mic_set_path(struct exynos_mic *mic, bool enable)
} else
val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
- regmap_write(mic->sysreg, DSD_CFG_MUX, val);
+ ret = regmap_write(mic->sysreg, DSD_CFG_MUX, val);
if (ret)
DRM_ERROR("mic: Failed to read system register\n");
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [patch 2/2] drm/exynos: mic: remove some dead code
2016-03-25 8:51 ` Inki Dae
2016-03-25 20:05 ` [patch 2/2 v2] drm/exynos: fix a warning message Dan Carpenter
@ 2016-03-25 20:09 ` Dan Carpenter
1 sibling, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2016-03-25 20:09 UTC (permalink / raw)
To: Inki Dae
Cc: Joonyoung Shim, Seung-Woo Kim, Kyungmin Park, David Airlie,
Kukjin Kim, Krzysztof Kozlowski, dri-devel, linux-samsung-soc,
linux-kernel, kernel-janitors
On Fri, Mar 25, 2016 at 05:51:20PM +0900, Inki Dae wrote:
> Hi Dan,
>
> 2016년 03월 17일 19:39에 Dan Carpenter 이(가) 쓴 글:
> > We know "ret" is zero and the test makes static checkers complain so
> > let's delete this printk.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > index 890c9b1..12db353 100644
> > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c
> > @@ -130,8 +130,6 @@ static void mic_set_path(struct exynos_mic *mic, bool enable)
> > val &= ~(MIC0_RGB_MUX | MIC0_I80_MUX | MIC0_ON_MUX);
> >
> > regmap_write(mic->sysreg, DSD_CFG_MUX, val);
> > - if (ret)
> > - DRM_ERROR("mic: Failed to read system register\n");
>
> I think we missed to keep return value from regmap_write function,
> ret = regmap_write(mic->sysreg, ....);
> if (ret)
> ...
Yeah. You're right.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-03-25 20:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-17 10:39 [patch 2/2] drm/exynos: mic: remove some dead code Dan Carpenter
2016-03-25 8:51 ` Inki Dae
2016-03-25 20:05 ` [patch 2/2 v2] drm/exynos: fix a warning message Dan Carpenter
2016-03-25 20:09 ` [patch 2/2] drm/exynos: mic: remove some dead code Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox