From: Sebastian Reichel <sre@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Ivaylo Dimitrov <ivo.g.dimitrov.75@gmail.com>,
tony@atomide.com, lgirdwood@gmail.com,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] regulator: twl: Enable regulators over the powerbus as well
Date: Fri, 25 Mar 2016 21:19:12 +0100 [thread overview]
Message-ID: <20160325201911.GA25471@earth> (raw)
In-Reply-To: <20160325182017.GE5028@sirena.org.uk>
[-- Attachment #1: Type: text/plain, Size: 1046 bytes --]
Hi Mark,
On Fri, Mar 25, 2016 at 06:20:17PM +0000, Mark Brown wrote:
> On Fri, Mar 25, 2016 at 07:22:45PM +0200, Ivaylo Dimitrov wrote:
>
> > On Nokia N900 regulators are left in the mode last set by the bootloader or
> > by the stock kernel, depends on whether it is power-on or reboot from stock
> > kernel to mainline. That leads to problem with devices connected to vmmc2
> > regulator - when the device is rebooted from stock kernel vmmc2 is left in
> > "sleep" mode (REGULATOR_STATUS_STANDBY in terms of regulator framework) and
> > as noone in mainline kernel switches vmmc2 regulator to normal
> > (REGULATOR_STATUS_NORMAL) mode, devices supplied by it does not get enough
> > power to operate normally.
>
> Then there is a constraint that the regulators must be in normal mode
> and this needs to be expressed in the machine constraints.
As in adding "regulator-initial-mode = <TWL4030_OPMODE_NORMAL>;" to
the regulator's DT node (and providing an of_map_mode method in the
twl-regulator driver)?
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-03-25 20:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-23 19:22 [PATCH] regulator: twl: Enable regulators over the powerbus as well Ivaylo Dimitrov
2016-03-25 11:17 ` Mark Brown
2016-03-25 15:02 ` Sebastian Reichel
2016-03-25 15:54 ` Mark Brown
2016-03-25 16:09 ` Ivaylo Dimitrov
2016-03-25 16:19 ` Mark Brown
2016-03-25 16:50 ` Ivaylo Dimitrov
2016-03-25 17:05 ` Mark Brown
2016-03-25 17:22 ` Ivaylo Dimitrov
2016-03-25 18:20 ` Mark Brown
2016-03-25 20:19 ` Sebastian Reichel [this message]
2016-03-25 22:28 ` Mark Brown
2016-03-26 6:18 ` Ivaylo Dimitrov
2016-03-25 16:47 ` Sebastian Reichel
2016-03-25 17:23 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160325201911.GA25471@earth \
--to=sre@kernel.org \
--cc=broonie@kernel.org \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox