From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753076AbcCZAng (ORCPT ); Fri, 25 Mar 2016 20:43:36 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:39539 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751962AbcCZAne (ORCPT ); Fri, 25 Mar 2016 20:43:34 -0400 Date: Sat, 26 Mar 2016 00:43:32 +0000 From: Al Viro To: Yaowei Bai Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/vfs: improve __mnt_is_readonly Message-ID: <20160326004332.GM17997@ZenIV.linux.org.uk> References: <1458871286-3099-1-git-send-email-baiyaowei@cmss.chinamobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1458871286-3099-1-git-send-email-baiyaowei@cmss.chinamobile.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 25, 2016 at 10:01:26AM +0800, Yaowei Bai wrote: > This patch refactors __mnt_is_readonly and makes it return bool to > improve readability due to this particular function only using either > one or zero as its return value. Improve in which way, if I may ask?