From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755433AbcC1V7a (ORCPT ); Mon, 28 Mar 2016 17:59:30 -0400 Received: from ipmail06.adl2.internode.on.net ([150.101.137.129]:18319 "EHLO ipmail06.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752562AbcC1V71 (ORCPT ); Mon, 28 Mar 2016 17:59:27 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2D/BwAsqPlWPDGaLHldgy5TfaZuAQQHjA2JbCGFZgICAQECgSNNAQEBAQEBBwEBAQFBQIRCAQEEOhwjEAgDGAklDwUlAwcaE4gmD8A3AQsBHRmFPIUMgTcBiFoFl2GFcYgLgj2MWI8LgnKBaSgwiHoBAQE Date: Tue, 29 Mar 2016 08:59:23 +1100 From: Dave Chinner To: Geert Uytterhoeven Cc: "linux-kernel@vger.kernel.org" , xfs@oss.sgi.com, Cris , Rich Felker , Linux-sh list Subject: Re: Build regressions/improvements in v4.6-rc1 Message-ID: <20160328215923.GG11812@dastard> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Mar 27, 2016 at 02:43:24PM +0200, Geert Uytterhoeven wrote: > On Sun, Mar 27, 2016 at 2:39 PM, Geert Uytterhoeven > wrote: > > Below is the list of build error/warning regressions/improvements in > > v4.6-rc1[1] compared to v4.5[2]. > > > > Summarized: > > - build errors: +9/-6 > > > [1] http://kisskb.ellerman.id.au/kisskb/head/10114/ (all 262 configs) > > [2] http://kisskb.ellerman.id.au/kisskb/head/10047/ (all 262 configs) > > > 9 error regressions: > > + /home/kisskb/slave/src/fs/xfs/xfs_ondisk.h: error: call to > > '__compiletime_assert_79' declared with attribute error: XFS: > > sizeof(xfs_attr_shortform_t) is wrong, expected 8: => 79:2 > > cris-allyesconfig, cris-allmodconfig Yup, cris is the only platform that throws this error on this structure. It's an on-disk structure and relying on the gcc optimiser to do the same thing from release to release has become such a crap-shoot these days. Hence as a stop-gap measure we added build time checking of what they compiler is doing with those structures, and to refuse to build XFS if the compiler/platform is doing something obviously different. Modernising the on-disk structure definitions is on the list of things to do, but it's nowhere near the top of my list at the moment... Cheers, Dave. -- Dave Chinner david@fromorbit.com