From: Christoph Hellwig <hch@infradead.org>
To: Shaohua Li <shli@fb.com>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
axboe@fb.com, hch@infradead.org, Kernel-team@fb.com
Subject: Re: [PATCH 1/3] blk-mq: add an API to estimate hardware queue node
Date: Tue, 29 Mar 2016 00:24:43 -0700 [thread overview]
Message-ID: <20160329072443.GA18920@infradead.org> (raw)
In-Reply-To: <68fed570910230ce847f8f3b685eeea399640a7f.1458941500.git.shli@fb.com>
On Fri, Mar 25, 2016 at 02:36:30PM -0700, Shaohua Li wrote:
> we allocate most data structure in device's node, but some data
> structures are not for DMA and mostly used by specific cpus/node which
> could diff from device's node. Allocating such hot data in device's
> node doesn't make sense. Add an API to estimate hardware queue node.
> This can be used before blk-mq actually establishes the mapping. This
> API runs slow, but it only used in initialization time.
I think this is the wrong way around. I've got some proprotype code
that just leaves the cpu assignments to the drivers and picks it up
in blk-mq. Give me a few days to post it..
next prev parent reply other threads:[~2016-03-29 7:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-25 21:36 [PATCH 1/3] blk-mq: add an API to estimate hardware queue node Shaohua Li
2016-03-25 21:36 ` [PATCH 2/3] blk-mq: allocate blk_mq_tags and requests in correct node Shaohua Li
2016-03-25 21:36 ` [PATCH 3/3] nvme: allocate nvme_queue " Shaohua Li
2016-03-29 7:24 ` Christoph Hellwig [this message]
2016-03-29 16:47 ` [PATCH 1/3] blk-mq: add an API to estimate hardware queue node Shaohua Li
2016-03-29 16:50 ` Jens Axboe
2016-03-29 17:44 ` Christoph Hellwig
2016-03-29 20:51 ` Jens Axboe
2016-03-29 21:20 ` Christoph Hellwig
2016-03-29 21:22 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160329072443.GA18920@infradead.org \
--to=hch@infradead.org \
--cc=Kernel-team@fb.com \
--cc=axboe@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shli@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox