From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755949AbcC2H0C (ORCPT ); Tue, 29 Mar 2016 03:26:02 -0400 Received: from mail.skyhub.de ([78.46.96.112]:43381 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751185AbcC2H0A (ORCPT ); Tue, 29 Mar 2016 03:26:00 -0400 Date: Tue, 29 Mar 2016 09:25:57 +0200 From: Borislav Petkov To: Huang Rui Cc: Guenter Roeck , Jean Delvare , linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org, spg_linux_kernel@amd.com Subject: Re: [PATCH v5 4/6] hwmon: (fam15h_power) Introduce a cpu accumulated power reporting algorithm Message-ID: <20160329072557.GA3705@pd.tnic> References: <1459143136-2412-1-git-send-email-ray.huang@amd.com> <1459143136-2412-5-git-send-email-ray.huang@amd.com> <20160328093327.GC26651@pd.tnic> <20160329032847.GB18406@hr-amur2> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160329032847.GB18406@hr-amur2> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 29, 2016 at 11:28:48AM +0800, Huang Rui wrote: > I checked with HW designer, milliseconds is also a reasonable interval > of acc power. And I cannot set too long here, because several seconds > will cause the read function to hang for that period of time. Exactly this justification should be as a comment in the code above the setting of the default value. > So I pick 10ms here, and actually, we can update the interval at > /etc/sensors3.conf > > chip "fam15h_power-*" > set power1_average_interval 0.01 I think this text should be in Documentation/hwmon/fam15h_power for users to know. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply.